This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Make required numpy version for setup and install explicit. #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postrational
suggested changes
Jul 3, 2019
python/requirements.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| six | |||
| numpy==1.15.4; python_version == "3.4" | |||
| numpy; python_version != "3.4" | |||
| numpy==1.16.4; python_version != "3.4" | |||
There was a problem hiding this comment.
I think we should we hard-code only for Python 2.7 and 3.4.
Let the user use latest version (or version required by other packages) in other cases.
python/setup.py
Outdated
| @@ -363,6 +363,22 @@ def build_extensions(self): | |||
| build_ext.build_extensions(self) | |||
|
|
|||
|
|
|||
| setup_requires = [ | |||
| 'numpy==1.15.4; python_version == "3.4"', | |||
| 'numpy==1.16.4; python_version != "3.4"', | |||
There was a problem hiding this comment.
Can we avoid replicating this code by parsing the requirements.txt file?
This should work:
setup_requires = open('requirements.txt').read().splitlines()
|
@aslepko @postrational I have made all the requested changes. Should we merge this PR or #3164 to master? #3162 which is identical to #3164 was merged to r0.23 |
postrational
approved these changes
Jul 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to generalize #3162 and avoid building numpy from source
numpy 1.15 is the last binary wheel to support python 3.4
numpy 1.16 seems like the last binary wheel to support python 2.7
Also trying to avoid the issue mentioned here
pytest-dev/pytest-xdist#136
This PR assumes nGraph supports python 2.7, 3.4, 3.5, 3.6, 3.7