feat(state): Integrate new state package with Juno #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
done event filter this works
use hashFn
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (59.21%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
+ Coverage 72.19% 72.35% +0.16%
==========================================
Files 262 259 -3
Lines 28368 27659 -709
==========================================
- Hits 20479 20012 -467
+ Misses 6496 6346 -150
+ Partials 1393 1301 -92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: MaksymMalicki <[email protected]>
Signed-off-by: MaksymMalicki <[email protected]>
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
Signed-off-by: MaksymMalicki <[email protected]>
…indEth/juno into maksym/state-integration
Comment on lines
-56
to
61
| var stateClassHash *felt.Felt | ||
| var stateClassHash felt.Felt | ||
| if reader == nil { | ||
| // zero block | ||
| stateClassHash = &felt.Zero | ||
| stateClassHash = felt.Zero | ||
| } else { |
There was a problem hiding this comment.
stateClassHash := felt.Zero
if reader != nil {
...
}
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stateDiagram-v2 classDef merged fill:#e1bee7,stroke:#9c27b0,stroke-width:2px,color:#4a148c classDef ready fill:#c8e6c9,stroke:#4caf50,stroke-width:2px,color:#1b5e20 classDef pending fill:#fff9c4,stroke:#ffeb3b,stroke-width:2px,color:#f57f17 classDef draft fill:#686868,stroke:#686868,stroke-width:2px,color:#C8C8C8 state "feat(state): Integrate new state package with Juno (#2912)" as integration state "refactor(DB): db storage optimizations (#2948)" as storageoptimizations state "refactor(juno): remove indexed batch (#2968)" as indexedbatch storageoptimizations --> integration indexedbatch --> integration class merged class ready class pending class integration, storageoptimizations, indexedbatch draftstateDiagram-v2 classDef merged fill:#e1bee7,stroke:#9c27b0,stroke-width:2px,color:#4a148c classDef ready fill:#c8e6c9,stroke:#4caf50,stroke-width:2px,color:#1b5e20 classDef pending fill:#fff9c4,stroke:#ffeb3b,stroke-width:2px,color:#f57f17 classDef draft fill:#686868,stroke:#686868,stroke-width:2px,color:#C8C8C8 state "🟣 Merged" as legendMerged state "🟢 Ready for Review (Good Test Coverage)" as legendReady state "🟡 Implementation Complete (Pending Tests)" as legendPending state "⚪️ Draft (WiP)" as legendDraft class legendMerged merged class legendReady ready class legendPending pending class legendDraft draft