tests: implement p2p sync tests #2982
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rianhughes
force-pushed
the
rianhughes/p2p-mock
branch
from
a5d2941 to
e0b4b25
Compare
rianhughes
force-pushed
the
rianhughes/p2p-mock
branch
from
3cd5b0a to
bd5ccfa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2982 +/- ##
==========================================
+ Coverage 71.77% 72.66% +0.89%
==========================================
Files 267 269 +2
Lines 28811 28945 +134
==========================================
+ Hits 20678 21033 +355
+ Misses 6737 6474 -263
- Partials 1396 1438 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
infrmtcs
reviewed
Jul 18, 2025
| time.Sleep(10 * time.Millisecond) | ||
| cancel() | ||
| }() | ||
| sync.Run(ctx) |
infrmtcs
reviewed
Jul 18, 2025
Comment on lines
+32
to
+34
| host := mocks.NewMockHost(mockCtrl) | ||
| sync := New(bc, host, &utils.Sepolia, utils.NewNopZapLogger()) | ||
| client := mocks.NewMockClient(mockCtrl) |
There was a problem hiding this comment.
I'm strongly against using mock here because by using mock, it means there are a lot of things untested:
- Non empty blocks.
- p2p initialization is done correctly, given correct configuration (because host is mocked)
- Server side: Query from database
- Server side, client side: Block streaming
- Server side, client side: Data serialization/deserialization with protobuf
I don't mean to insist that we need to write the tests for all of these above in this PR. What I meant is that instead of using mock here, we can at least have a simple test not using mock but cover most of the cases above. The idea is:
- Start 2 p2p hosts, connect to each other via libp2p. Examples can be found in consensus tests.
- One host plays the role of server. Store N blocks to its database.
- The other host plays the role of client. Run the sync protocol and validate whether it can fetch all N blocks from the server host.
- Assertions can be done easily but throughly, by verifying whether the stored blocks in client and server databases match exactly.
infrmtcs
reviewed
Jul 18, 2025
|
|
||
| ctx, cancel := context.WithCancel(t.Context()) | ||
| go func() { | ||
| time.Sleep(10 * time.Millisecond) |
There was a problem hiding this comment.
We should use eventually with the assertions below instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a test for the P2P sync pkg. The test involves syncing a single empty block from a peer.
Todo: add a non-empty block test