Skip to content

Custom SSL certificates not working correctly #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xorinzor opened this issue Nov 11, 2019 · 5 comments
Closed

Custom SSL certificates not working correctly #237

xorinzor opened this issue Nov 11, 2019 · 5 comments

Comments

@xorinzor
Copy link

xorinzor commented Nov 11, 2019

Adding letsencrypts certificates works great, but custom certificates is having quite a few issues.

  1. only RSA seems to be supported, trying to add a certificate from cloudflare using the ECDSA algorithm throws an error when you try to add it, as it fails to validate the certificate. (The error can also be only viewed via the console, it's not getting returned anywhere within the web interface)

  2. Just a visual glitch, but still confusing if you are unaware: the fields where you select a file will stay empty when a file is selected. This is just visual, because if you selected the proper key and certificate it will allow you to add the certificate.

  3. It doesn't seem to recognize the comma as a delimiter properly when entering the domain names.

And now where things really seem to go wrong:
Selecting the custom SSL certificate for a domain will return an internal server error, which will break that specific proxy host in the web interface until you manually fix it.

The reason for this is that it configures the path where it expects the certificate to be to "/etc/letsencrypt/live/" inside the "proxy_host/<id>.conf".

Which would work fine if it actually was a letsencrypt certificate, but our custom ssl is in a completely different location, that doesn't appear to be symlinked anywhere inside the docker container, and can only be accessed via the mount "/config" (if this has not been changed from it's default value for whatever reason, by the user).

As a result, any changes you attempt to make via the web interface fail as it will try to check the path of the certificate (or something similar, I can see something happening in the logs, but didn't dive too deep into it) and spit out an error.

@mfjonesy
Copy link

mfjonesy commented Nov 12, 2019

I can confirm issue #2. I was going crazy trying to figure out why it wasn't letting me select the files. Good thing I saw this! However once I added the custom SSL cert from cloudflare I was able to select it for my nextcloud proxy host with no issues.

@MatthiasMT
Copy link

First of all, amazing software done by the creator of this project!

Second i can also confirm this with some longs on whats happening.

image

Ill try to see if i can get it working without the GUI but that could take a while!

@xorinzor
Copy link
Author

xorinzor commented Nov 13, 2019

Ill try to see if i can get it working without the GUI but that could take a while!

Manually editing the proxy_host/"number".conf file and changing the ssl lines to the correct path did the trick for me. You just cannot use the GUI to manage this proxy_host until the issue is fixed.

(Keep in mind you need to change the path to where the certificate files are located inside the docker container, not the path where it's stored on the host)

@MatthiasMT
Copy link

MatthiasMT commented Nov 13, 2019

Ill try to see if i can get it working without the GUI but that could take a while!

Manually editing the proxy_host/"number".conf file and changing the ssl lines to the correct path did the trick for me. You just cannot use the GUI to manage this proxy_host until the issue is fixed.

(Keep in mind you need to change the path to where the certificate files are located inside the docker container, not the path where it's stored on the host)

Ahh good to know its possible and i dont have to store anything in the database?

Ill take a look tomorrow and see what i can get working, thanks xorinzor

@xorinzor
Copy link
Author

Ahh good to know its possible and i dont have to store anything in the database?

I wasn't aware that a database was being used, despite that, just manually editing the config file did the trick for me. Maybe if you edit the entry in the database it could fix some other issues, but that's just pure speculation as I have no idea what's being stored in the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants