-
Notifications
You must be signed in to change notification settings - Fork 3k
Enable PROXY procotol for proxy hosts and streams #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable PROXY procotol for proxy hosts and streams #3618
Conversation
CI is reporting:
Cypress output:
|
One question I do have: How should we show the user, that udp and proxy_protocol are exclusive options on a listener? Currently I just silently drop the proxy_protocol option for the UDP listener, but I am unsure that this is a good implementation. I imagine that we could also disable the UDP button, when "Enable Proxy Protocol" is pressed. |
Docker Image for build 6 is available on DockerHub as Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes. |
The plan was to fix the test next week |
what needs be done for mr @jc21 |
Any update on this? |
Any latest news about proxy_protocol? |
@jc21 would you be able to merge this PR when I resolve all the conflicts? |
tbh, might be easier to start again from the current develop branch. I will close this PR and open a new one once I am done with the re-implementation. |
Closes NginxProxyManager#1114 Related To NginxProxyManager#1882 Related To NginxProxyManager#3537 Related To NginxProxyManager#3618 Co-authored-by: jwklijnsma <[email protected]> Co-authored-by: SBado <[email protected]>
Closes NginxProxyManager#1114 Related To NginxProxyManager#1882 Related To NginxProxyManager#3537 Related To NginxProxyManager#3618 Co-authored-by: jwklijnsma <[email protected]> Co-authored-by: SBado <[email protected]>
Closes NginxProxyManager#1114 Related To NginxProxyManager#1882 Related To NginxProxyManager#3537 Related To NginxProxyManager#3618 Co-authored-by: jwklijnsma <[email protected]> Co-authored-by: SBado <[email protected]>
Closes NginxProxyManager#1114 Related To NginxProxyManager#1882 Related To NginxProxyManager#3537 Related To NginxProxyManager#3618 Co-authored-by: jwklijnsma <[email protected]> Co-authored-by: SBado <[email protected]>
Closes NginxProxyManager#1114 Related To NginxProxyManager#1882 Related To NginxProxyManager#3537 Related To NginxProxyManager#3618 Co-authored-by: jwklijnsma <[email protected]> Co-authored-by: SBado <[email protected]>
As I see not too much progress in #3537, I decided to copy most of the code and (try to) fix the tests.
In this PR I also included the code necessary to enable the PROXY protocol for Streams.
Thank you @jwklijnsma for the previous work