Skip to content

Commit cb4ab40

Browse files
committed
Merge branch 'master' into add_zoom_to_android_webview
* master: [image_picker] use LocalizedString to fix lint error. (flutter#3349) Upgrade CocoaPods in Cirrus (flutter#3347)
2 parents 63d7085 + 73eeb30 commit cb4ab40

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

.cirrus.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ task:
132132
osx_instance:
133133
image: catalina-xcode-11.3.1-flutter
134134
upgrade_script:
135+
- sudo gem install cocoapods
135136
- flutter channel stable
136137
- flutter upgrade
137138
- flutter channel master
@@ -190,6 +191,7 @@ task:
190191
setup_script:
191192
- flutter config --enable-macos-desktop
192193
upgrade_script:
194+
- sudo gem install cocoapods
193195
- flutter channel master
194196
- flutter upgrade
195197
- git fetch origin master

packages/image_picker/image_picker/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.6.7+17
2+
3+
* iOS: fix `User-facing text should use localized string macro` warning.
4+
15
## 0.6.7+16
26

37
* Update Flutter SDK constraint.

packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,10 @@ - (void)showCamera {
146146
animated:YES
147147
completion:nil];
148148
} else {
149-
[[[UIAlertView alloc] initWithTitle:@"Error"
150-
message:@"Camera not available."
149+
[[[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Error", nil)
150+
message:NSLocalizedString(@"Camera not available.", nil)
151151
delegate:nil
152-
cancelButtonTitle:@"OK"
152+
cancelButtonTitle:NSLocalizedString(@"OK", nil)
153153
otherButtonTitles:nil] show];
154154
self.result(nil);
155155
self.result = nil;

packages/image_picker/image_picker/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: image_picker
22
description: Flutter plugin for selecting images from the Android and iOS image
33
library, and taking new pictures with the camera.
44
homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker
5-
version: 0.6.7+16
5+
version: 0.6.7+17
66

77
flutter:
88
plugin:

0 commit comments

Comments
 (0)