Skip to content

Bug/2134 router session left logging crash #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DZabavchik
Copy link

Fixes a bug appearing when debug logging is enabled

Skully17 and others added 7 commits January 9, 2025 14:53
* Fixing test runners

* Fixing test runners

* Fixing test runners

* Fixing test runners

* update eth-abi

* update eth-abi

* update eth-abi

* update eth-abi

* update eth-account

* intersphinx_mapping format has changed

* Removed sphinxcontrib.images from list of extensions because sphinxcontrib-images v0.9.4 doesn't work with sphinx v8.1.3

* Using "isinstance" to compare types instead of "type(x) == y"

* Using "isinstance" to compare types instead of "type(x) == y"

* Changing formatting to satisfy yapf

* Resolving mypy errors and updating python version to 3.11

* Added timeouts for requests so to avoid them hanging indefinitely and to satisfy bandit

* - unskipping test as matterhorn is no longer being used
- skipping failing mqtt tests after migrate abck to using GitHub machines for CI testing

* - re-skipping test as it still fails on GitHub machine
- Satisfied yapf

* Removed testing on python 3.9

* Changed the CI trigger back to how it was for production

---------

Co-authored-by: David Ellis <[email protected]>
* - Corrected param name
- Added variable for repetitively accessed dictionary value
- extended if statement to also check if "sub" is not None to see if the subscription has actually been made.
- Added on_remote_leave to empty dictionary of forwarded subscriptions
- extended if statement to also check if "reg" is not None to see if the registration has actually been made.
- Made "create forwarding registration" log debug level to match the subscription one. This is expected functionality and there can be large amounts of registrations which would cause log spam.

* Implemented changes suggested by @DZabavchik:
- Improved process of adding subscription to _subs and registration to _regs
- sub needs to be unsubscribed, not unregistered

---------

Co-authored-by: David Ellis <[email protected]>
Co-authored-by: Tobias Oberstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants