Automatic retirement of @m1cr0man

[nixpkgs-committers]

This is an automated PR to retire @m1cr0man as a Nixpkgs committers due to not using their commit access for 1 year.

Make a comment with your motivation to keep commit access, otherwise this PR will be merged and implemented in 1 month.

[emilazy]

@m1cr0man just recently received commit access. I think the automation needs to take into account the date when someone got the bit.

[wolfgangwalther]

I think there's something else going wrong here, but not sure. IIUC, the api endpoint the automation is looking at should also count commits from when he was not a committer. His last PR was https://github.com/NixOS/nixpkgs/pull/378705/commits, in February this year. That should certainly count.

But in that PR commits tab mentioned above, I click on his name and it leads me to https://github.com/NixOS/nixpkgs/commits?author=m1cr0man. I should see all his commits, but at least I only get an empty page there and it says "no commits history".

[emilazy]

It is not empty for me. Thanks, GitHub.

[wolfgangwalther]

Seems like I work too much on CI, so I get the same output that CI has :D

Edit: Now, I can see his commits as well. I'd assume that CI would as well, so this should be good to close.

[emilazy]

Perhaps there should be a failsafe for the case of literally no commits – presumably a situation that describes no committer.

[wolfgangwalther]

It looks like the actual request already takes a time period "year", so "no commit / activity" actually is expected..

nixpkgs-committers/scripts/retire.sh

Lines 55 to 70 in 93d7094

	trace gh api -X GET /repos/"$ORG"/"$ACTIVITY_REPO"/activity \
	-f time_period=year \
	-f actor="$login" \
	-f per_page=100 \
	--jq '.[] |
	"- \(.timestamp) [\(.activity_type) on \(.ref | ltrimstr("refs/heads/"))](https://github.com/'"$ORG/$ACTIVITY_REPO"'/\(
	if .activity_type == "branch_creation" then
	"commit/\(.after)"
	elif .activity_type == "branch_deletion" then
	"commit/\(.before)"
	else
	"compare/\(.before)...\(.after)"
	end
	))"' \
	> "$tmp/$login"
	activityCount=$(wc -l <"$tmp/$login")

[wolfgangwalther]

Maybe there should be a case of closing this PR automatically when the committer makes a commit.

Then this error would be recovered from automatically.

[emilazy]

We could just query the single most recent commit, check its date, and consider the query to have failed if it returns no results, right?

[infinisil]

Oh yeah, sorry this is a mistake I made in CI. I did think of this when I wrote it, but don't remember why I thought it wouldn't be a problem.

I'll close this and will temporarily disable the retire workflow until we have this fixed. Please use #30 to discuss solutions to this.