-
-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Update request: python3Packages.openai-triton 2.0.0 → 2.1.1 #271212
Copy link
Copy link
Closed
Labels
6.topic: cudaParallel computing platform and APIParallel computing platform and API6.topic: rocmROCm is an Advanced Micro Devices software stack for graphics processing unit programming.ROCm is an Advanced Micro Devices software stack for graphics processing unit programming.9.needs: package (update)This needs a package to be updatedThis needs a package to be updated
Metadata
Metadata
Assignees
Labels
6.topic: cudaParallel computing platform and APIParallel computing platform and API6.topic: rocmROCm is an Advanced Micro Devices software stack for graphics processing unit programming.ROCm is an Advanced Micro Devices software stack for graphics processing unit programming.9.needs: package (update)This needs a package to be updatedThis needs a package to be updated
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
✅ Done
PyTorch's
torch.compileis/will be broken by #259068 (which is fine, becausepython3Packages.openai-tritonis a separate package and should be updated separately).Triton lives doesn't seem to be cutting releases. PyTorch has pinned commits they use:
https://github.com/pytorch/pytorch/blob/4c55dc50355d5e923642c59ad2a23d6ad54711e7/.ci/docker/ci_commit_pins/triton.txt#L1
https://github.com/pytorch/pytorch/blob/4c55dc50355d5e923642c59ad2a23d6ad54711e7/.ci/docker/ci_commit_pins/triton-rocm.txt#L1
Their CI uses these commits to fetch Triton from the corresponding repo (upstream for CUDA, and the AMD's fork for ROCm):
https://github.com/pytorch/pytorch/blob/4c55dc50355d5e923642c59ad2a23d6ad54711e7/.ci/docker/common/install_triton.sh#L15-L21
This presents some complications for us, at least for the release of Triton which corresponds to PyTorch 2.1.1 -- we have different sources for CUDA and ROCm. (Hopefully this will be resolved as upstream continue to merge fixes for ROCm.)
Relatedly, I had apparently tried to do this bump some time ago. That may be useful: ConnorBaker@3071319
Notify maintainers
@NixOS/cuda-maintainers @NixOS/rocm-maintainers @SomeoneSerge @Madouura
Note for maintainers: Please tag this issue in your PR.
Priorities
Add a 👍 reaction to issues you find important.