python3Packages.openai-triton: narrow the definition of broken#261654
Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom Oct 18, 2023
Merged
python3Packages.openai-triton: narrow the definition of broken#261654ConnorBaker merged 1 commit intoNixOS:masterfrom
ConnorBaker merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Contributor
Author
|
Result of |
56a5b78 to
5e6b3ee
Compare
5e6b3ee to
403955e
Compare
403955e to
e2865d4
Compare
e2865d4 to
563f516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Working on #256324, this allows us to build LLVM for the Jetson.
Additionally makes the AMD and NVIDIA backends mutually exclusive to reduce closure size.AMD and NVIDIA backends are not mutually here. Triton actually requires that both be present: https://github.com/openai/triton/blob/768fc1fcd98ecfc0892f8982b0bb009dd7bb11ea/CMakeLists.txt#L73.Thank you @Madouura for making this a separate derivation!
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)