Skip to content

python3Packages.openai-triton: narrow the definition of broken#261654

Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom
ConnorBaker:fix/openai-triton-arm-cuda-support
Oct 18, 2023
Merged

python3Packages.openai-triton: narrow the definition of broken#261654
ConnorBaker merged 1 commit intoNixOS:masterfrom
ConnorBaker:fix/openai-triton-arm-cuda-support

Conversation

@ConnorBaker
Copy link
Copy Markdown
Contributor

@ConnorBaker ConnorBaker commented Oct 17, 2023

Description of changes

Working on #256324, this allows us to build LLVM for the Jetson. Additionally makes the AMD and NVIDIA backends mutually exclusive to reduce closure size. AMD and NVIDIA backends are not mutually here. Triton actually requires that both be present: https://github.com/openai/triton/blob/768fc1fcd98ecfc0892f8982b0bb009dd7bb11ea/CMakeLists.txt#L73.

Thank you @Madouura for making this a separate derivation!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ConnorBaker ConnorBaker added 0.kind: enhancement Add something new or improve an existing system. 6.topic: cuda Parallel computing platform and API labels Oct 17, 2023
@ConnorBaker ConnorBaker requested a review from Madouura October 17, 2023 14:51
@ConnorBaker ConnorBaker self-assigned this Oct 17, 2023
@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 17, 2023
@ConnorBaker
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 261654 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; cudaCapabilities = [ "8.9" ]; }' run on x86_64-linux 1

@ConnorBaker ConnorBaker force-pushed the fix/openai-triton-arm-cuda-support branch from 56a5b78 to 5e6b3ee Compare October 17, 2023 16:42
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 17, 2023
@ConnorBaker ConnorBaker force-pushed the fix/openai-triton-arm-cuda-support branch from 5e6b3ee to 403955e Compare October 17, 2023 18:10
Copy link
Copy Markdown
Member

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 17, 2023
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 17, 2023
Comment thread pkgs/development/python-modules/openai-triton/llvm.nix Outdated
@ConnorBaker ConnorBaker force-pushed the fix/openai-triton-arm-cuda-support branch from 403955e to e2865d4 Compare October 18, 2023 13:42
@ConnorBaker ConnorBaker force-pushed the fix/openai-triton-arm-cuda-support branch from e2865d4 to 563f516 Compare October 18, 2023 13:43
@ConnorBaker ConnorBaker merged commit d26b6de into NixOS:master Oct 18, 2023
@ConnorBaker ConnorBaker deleted the fix/openai-triton-arm-cuda-support branch October 18, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system. 6.topic: cuda Parallel computing platform and API 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants