openai-triton-llvm: fix aarch64 and cross-compilation#267209
Merged
wegank merged 3 commits intoNixOS:masterfrom Nov 17, 2023
Merged
openai-triton-llvm: fix aarch64 and cross-compilation#267209wegank merged 3 commits intoNixOS:masterfrom
wegank merged 3 commits intoNixOS:masterfrom
Conversation
ofborg
Bot
added
the
6.topic: cross-compilation
github-actions
Bot
added
the
6.topic: python
13 tasks
ofborg
Bot
requested review from
SomeoneSerge,
teh,
thoughtpolice and
tscholak
ofborg
Bot
added
10.rebuild-darwin: 101-500
Madouura
force-pushed
the
pr/triton-llvm
branch
from
8bb0f73 to
b23fa14
Compare
Madouura
force-pushed
the
pr/triton-llvm
branch
from
b23fa14 to
7531b5a
Compare
Contributor
Author
|
cc @RaitoBezarius |
Member
|
Hi there, I can only review this in December as my bandwidth is severely low due to upcoming release and various engagements. I would recommend posting in the cross compilation channel. |
Contributor
Author
|
The tests do pass on
No problem, I'll post this PR there. |
Madouura
force-pushed
the
pr/triton-llvm
branch
from
7531b5a to
45f5a74
Compare
Contributor
Author
|
I just realized I messed up badly with the cross code. |
Madouura
force-pushed
the
pr/triton-llvm
branch
from
45f5a74 to
c0b83bb
Compare
Contributor
Author
|
Good thing I caught that, I guess tests only passed because they're not in |
Contributor
|
The diff LGTM, just running the builds now ❯ nix build github:Madouura/nixpkgs/pr/triton-llvm#pkgsCross.aarch64-multiplatform.python3Packages.torchWithRocm
error:
… while evaluating the attribute 'drvPath'
...
at /nix/store/zkjx4b3klwrsc3gk4pn3pi3j1hvqaws0-source/lib/customisation.nix:247:7:
...
(stack trace truncated; use '--show-trace' to show the full trace)
error: Package ‘rocm-llvm-llvm-5.7.1’ in /nix/store/zkjx4b3klwrsc3gk4pn3pi3j1hvqaws0-source/pkgs/development/rocm-modules/5/llvm/base.nix:160 is marked as broken, refusing to evaluate.Is this expected? (Ofborg skipping darwin for the same reason?) @azuwis could you please test |
Contributor
|
Contributor
Author
Any chance you could test |
Contributor
I don't have a |
Contributor
Author
For now, let's keep darwin support guarded on torch then. |
Contributor
|
@ofborg build python3Packages.torch |
Contributor
Author
Why is torch failing on |
Member
On this branch |
Contributor
|
Result of 28 packages marked as broken and skipped:
38 packages failed to build:
486 packages built:
|
Contributor
|
Indeed, eval looks fine: @Artturin why does ofborg care about whether torch evals on master? |
Member
It doesn't, I just said it because @Madouura thought it was broken on this branch too. |
Contributor
|
Is this about master? Because I don't see how can it be about the current branch |
Member
|
@ofborg build python311Packages.torch |
Contributor
Author
|
nixpkgs/pkgs/development/python-modules/torch/default.nix Lines 292 to 293 in 332d8dc We can likely fix the aarch64-darwin error by adding the following under this:
"-Wno-error=maybe-uninitialized"
"-Wno-error=stringop-overflow"I don't really want to over-complicate this PR with these kinds of fixes though and I have no way of actually testing darwin without annoying people with ofborg access until it works. |
Contributor
|
Did ofborg tried to merge master before build? But https://github.com/NixOS/nixpkgs/pull/267209/checks?check_run_id=18767769137 shows it tried to build /nix/store/wy6alr3i3883c43ir6n20w0x7112j0n9-python3.11-torch-2.0.1.drv |
13 tasks
Member
|
From the error message on
(A commit named The |
Cross-compilation code taken/modified from LLVM 16 derivation
Guard this option against 'stdenv.isDarwin', which currently is unknown whether it works or not.
wegank
force-pushed
the
pr/triton-llvm
branch
from
c0b83bb to
e3d4bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes this comment: #263048 (comment)
Unsure how to test darwin, since it won't cross-compile.
This is why we're guarding
openai-tritonintorch: 8bb0f732cf7638a0749a26fe37b60db1032daf55Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)