Skip to content

roave-backward-compatibility-check: init at 8.8.0 #313907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

roave-backward-compatibility-check: init at 8.8.0 #313907

merged 1 commit into from
May 23, 2024
+37 −0

Conversation

drupol
Copy link
Contributor

@drupol drupol commented May 23, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol force-pushed the init/php/roave-backward-compatibility-check-8-8-0 branch from 1b3d735 to b4c16b0 Compare May 23, 2024 07:57
@drupol drupol marked this pull request as ready for review May 23, 2024 07:57
@drupol drupol mentioned this pull request May 23, 2024
Merged
@drupol drupol force-pushed the init/php/roave-backward-compatibility-check-8-8-0 branch 2 times, most recently from 474ad97 to adff10c Compare May 23, 2024 08:00
@drupol drupol requested review from aanderse, globin, Ma27 and talyz as code owners May 23, 2024 08:00
@github-actions github-actions bot added the 6.topic: php PHP is a general-purpose scripting language geared towards web development. label May 23, 2024
@drupol drupol force-pushed the init/php/roave-backward-compatibility-check-8-8-0 branch from adff10c to aed4194 Compare May 23, 2024 08:01
@github-actions github-actions bot removed the 6.topic: php PHP is a general-purpose scripting language geared towards web development. label May 23, 2024
@drupol drupol force-pushed the init/php/roave-backward-compatibility-check-8-8-0 branch from aed4194 to f5fec18 Compare May 23, 2024 08:02
patka-123
patka-123 approved these changes May 23, 2024
View reviewed changes
@drupol drupol force-pushed the init/php/roave-backward-compatibility-check-8-8-0 branch from f5fec18 to f70ed7a Compare May 23, 2024 08:52
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 23, 2024
@ofborg ofborg bot requested a review from patka-123 May 23, 2024 08:54
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 23, 2024
@ofborg ofborg bot requested a review from patka-123 May 23, 2024 09:49
@drupol drupol merged commit 1cfee33 into NixOS:master May 23, 2024
@drupol drupol deleted the init/php/roave-backward-compatibility-check-8-8-0 branch May 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@talyz talyz Awaiting requested review from talyz

@patka-123 patka-123 Awaiting requested review from patka-123

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @patka-123