json2ts: fix build on darwin; allow case insensitive import #358398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsjobeki
force-pushed
the
fix/json2ts
branch
from
8829706 to
e4b8d93
Compare
hsjobeki
added
0.kind: ZHF Fixes
hsjobeki
force-pushed
the
fix/json2ts
branch
3 times, most recently
from
f33d55a to
f07a550
Compare
hsjobeki
force-pushed
the
fix/json2ts
branch
from
f07a550 to
36f68a9
Compare
imincik
approved these changes
Nov 23, 2024
Contributor
imincik
left a comment
imincik
left a comment
There was a problem hiding this comment.
Diff looks good.
Manually tested on darwin
nix-build --argstr system aarch64-darwin -A json2ts
/nix/store/g6s4342v2n0x4bg88c6r1j343xdh5vkk-json2ts
Contributor
Author
|
Fiy: bcherny/json-schema-to-typescript#644 We can remove the fix once this is fixed upstream. |
tricktron
approved these changes
Nov 23, 2024
Member
tricktron
left a comment
tricktron
left a comment
There was a problem hiding this comment.
Builds on aarch64-darwin and x86_64-darwin
Member
|
Member
|
@ofborg build json2ts json2ts.passthru.tests |
Contributor
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darwins case (in-)sensitive file-system behavior of typescript causes this package to fail:
https://www.typescriptlang.org/tsconfig/#forceConsistentCasingInFileNames
default: trueI used jq to set it to false in
postConfigure.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
#ZurichZHF