Skip to content

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Dec 9, 2024

Things done

Follow-up of #362844

This adds a new key to the JSON generated by the compare function.
It lists the rebuilds for each platform.
This will make Mic92/nixpkgs-review#433 way easier.

cc @infinisil @Mic92

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Dec 9, 2024
@GaetanLepage GaetanLepage force-pushed the compare-nix branch 2 times, most recently from cc706c5 to 3e989d4 Compare December 9, 2024 22:38
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 9, 2024
@Mic92
Copy link
Member

Mic92 commented Dec 10, 2024

Test run: Mic92#40

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Dec 10, 2024

Test run: Mic92#40

It seems like the comparison step does not run.

@Mic92
Copy link
Member

Mic92 commented Dec 11, 2024

Test run: Mic92#40

It seems like the comparison step does not run.

@infinisil how can we test this in our own forks?

@infinisil
Copy link
Member

@Mic92 Need to also push something on the master branch to get the eval there going

@GaetanLepage GaetanLepage marked this pull request as draft December 11, 2024 10:59
@GaetanLepage GaetanLepage marked this pull request as ready for review December 11, 2024 12:44
@GaetanLepage GaetanLepage force-pushed the compare-nix branch 2 times, most recently from 6dffe9d to 1410eea Compare December 11, 2024 12:53
@Mic92
Copy link
Member

Mic92 commented Dec 11, 2024

Ah maybe the issue is that my base branch is called main and not master?

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Dec 11, 2024

@Mic92 Mic92 merged commit f5c4230 into NixOS:master Dec 11, 2024
20 of 21 checks passed
@GaetanLepage
Copy link
Contributor Author

{
  "attrdiff": {
    "added": [
      "gh-cal-bis"
    ],
    "changed": [
      "python311Packages.equinox",
      "python311Packages.flowmc",
      "python311Packages.lineax",
      "python311Packages.optimistix",
      "python312Packages.equinox",
      "python312Packages.flowmc",
      "python312Packages.lineax",
      "python312Packages.optimistix"
    ],
    "removed": [
      "materialize",
      "quake3demo"
    ]
  },
  "labels": [
    "10.rebuild-darwin: 1-10",
    "10.rebuild-linux: 1-10"
  ],
  "rebuildCountByKernel": {
    "darwin": 9,
    "linux": 9
  },
  "rebuildsByKernel": {
    "darwin": [
      "gh-cal-bis",
      "python311Packages.equinox",
      "python311Packages.flowmc",
      "python311Packages.lineax",
      "python311Packages.optimistix",
      "python312Packages.equinox",
      "python312Packages.flowmc",
      "python312Packages.lineax",
      "python312Packages.optimistix"
    ],
    "linux": [
      "gh-cal-bis",
      "python311Packages.equinox",
      "python311Packages.flowmc",
      "python311Packages.lineax",
      "python311Packages.optimistix",
      "python312Packages.equinox",
      "python312Packages.flowmc",
      "python312Packages.lineax",
      "python312Packages.optimistix"
    ]
  },
  "rebuildsByPlatform": {
    "aarch64-darwin": [
      "gh-cal-bis",
      "python311Packages.equinox",
      "python311Packages.flowmc",
      "python311Packages.lineax",
      "python311Packages.optimistix",
      "python312Packages.equinox",
      "python312Packages.flowmc",
      "python312Packages.lineax",
      "python312Packages.optimistix"
    ],
    "aarch64-linux": [
      "gh-cal-bis",
      "python311Packages.equinox",
      "python311Packages.flowmc",
      "python311Packages.lineax",
      "python311Packages.optimistix",
      "python312Packages.equinox",
      "python312Packages.flowmc",
      "python312Packages.lineax",
      "python312Packages.optimistix"
    ],
    "x86_64-darwin": [
      "gh-cal-bis",
      "python311Packages.equinox",
      "python311Packages.lineax",
      "python311Packages.optimistix",
      "python312Packages.equinox",
      "python312Packages.lineax",
      "python312Packages.optimistix"
    ],
    "x86_64-linux": [
      "gh-cal-bis",
      "python311Packages.equinox",
      "python311Packages.flowmc",
      "python311Packages.lineax",
      "python311Packages.optimistix",
      "python312Packages.equinox",
      "python312Packages.flowmc",
      "python312Packages.lineax",
      "python312Packages.optimistix"
    ]
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants