Skip to content

Conversation

infinisil
Copy link
Member

Discovered in #368656 (comment)

Ping @SigmaSquadron

Things done

  • Tested get-code-owners.sh locally with a commit that changes a file with a filename that has a space

This work is funded by Tweag and Antithesis

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Jan 9, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 9, 2025
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 9, 2025
@infinisil infinisil merged commit 2b536d0 into NixOS:master Jan 9, 2025
26 of 30 checks passed
@infinisil infinisil deleted the fix-code-owners-space-files branch January 9, 2025 19:00
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 11, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants