ISSUE_TEMPLATE: avoid using maintainer usernames as headings #387825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#368656 moved the issue templates to YAML; this is awesome, but had the (unintentional?) side-effect of making the low-effort way to tag maintainers use markdown heading markup for the tags, rather than the previously-used horizontal rule below them.
If you tag a maintainer like this:
The result looks like this:
I suspect what was intended was instead this:
This change is already visible in recent issues, e.g. #387705:
whereas older issues (searching for
"note for maintainers" created:<2025-01-13
, e.g. #362118) consistently use normal text followed by a horizontal rule:@SigmaSquadron as the author of #368656, please do shout if this change was deliberate!
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.