Skip to content

Conversation

keysmashes
Copy link
Contributor

#368656 moved the issue templates to YAML; this is awesome, but had the (unintentional?) side-effect of making the low-effort way to tag maintainers use markdown heading markup for the tags, rather than the previously-used horizontal rule below them.

If you tag a maintainer like this:

image

The result looks like this:

image

I suspect what was intended was instead this:

image

image


This change is already visible in recent issues, e.g. #387705:

image

whereas older issues (searching for "note for maintainers" created:<2025-01-13, e.g. #362118) consistently use normal text followed by a horizontal rule:

image

@SigmaSquadron as the author of #368656, please do shout if this change was deliberate!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels Mar 7, 2025
@nix-owners nix-owners bot requested a review from SigmaSquadron March 7, 2025 08:51
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 7, 2025
@FliegendeWurst FliegendeWurst merged commit c25a593 into NixOS:master Mar 12, 2025
27 checks passed
@FliegendeWurst
Copy link
Member

There are actually more affected templates, for example the bug report templates. I'll take care of it later, or you can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants