Skip to content

somo: init at 1.1.0 #423741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

somo: init at 1.1.0 #423741

merged 1 commit into from
Jul 9, 2025

Conversation

@kachick
Copy link
Member

@kachick kachick commented Jul 9, 2025 •
edited
Loading

Add somo, a user-friendly netstat alternative for socket and port monitoring. It currently supports Linux and macOS.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed # Initially relaxed, and enabled after found the libclang.dylib error on sandbox mode
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 9, 2025
@kachick

This comment was marked as outdated.

Sign in to view
@Flokkq
Copy link
Contributor

Flokkq commented Jul 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 423741
Commit: 68d908ef46401199959ae3955bdd7a6dc8bb17d5

x86_64-linux

✅ 1 package built:
  • somo

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 9, 2025
Defelo
Defelo reviewed Jul 9, 2025
View reviewed changes
@kachick kachick marked this pull request as draft July 9, 2025 13:37
Defelo
Defelo approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your changes into the somo: init at 1.1.0 commit. Other than that, LGTM!

@Defelo
Copy link
Member

Defelo commented Jul 9, 2025

And don't forget to mark this as ready for review again 😉

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 9, 2025
@kachick kachick marked this pull request as ready for review July 9, 2025 14:04
@Defelo

This comment was marked as outdated.

Sign in to view
@kachick

This comment was marked as outdated.

Sign in to view
@kachick kachick marked this pull request as draft July 9, 2025 14:36
@kachick kachick marked this pull request as ready for review July 9, 2025 15:29
@kachick

This comment was marked as outdated.

Sign in to view
@kachick

This comment was marked as resolved.

Sign in to view
@kachick kachick marked this pull request as draft July 9, 2025 15:42
Defelo
Defelo reviewed Jul 9, 2025
View reviewed changes
@kachick @Defelo
somo: init at 1.1.0
93b8f2e 
Defelo refined this package with following points

* avoid `finalAttrs.src` in `meta.changelog`
* remove redundant code of `versionCheckProgram`

Co-authored-by: Felix Bargfeldt <[email protected]>
@kachick kachick marked this pull request as ready for review July 9, 2025 15:47
@kachick
Copy link
Member Author

kachick commented Jul 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 423741
Commit: 93b8f2e320e054e8cf55c31fbc1be1c9750b1d96

x86_64-linux

✅ 1 package built:
  • somo

aarch64-linux

✅ 1 package built:
  • somo

x86_64-darwin

✅ 1 package built:
  • somo

aarch64-darwin

✅ 1 package built:
  • somo

@Defelo
Copy link
Member

Defelo commented Jul 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 423741

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/16174047399

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-423741-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/g53ivy1g1wb49b6jysdmnnhcjks4v0bk-somo-1.1.0
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-423741-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/v2q069fwqzxfmgfpbbb86yg4vmh11yzv-somo-1.1.0
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-423741-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/ji31ycr1hqdwp993hsrrbrfzmqyqnf1g-somo-1.1.0

x86_64-linux

✅ 1 package built:
  • somo

aarch64-linux

✅ 1 package built:
  • somo

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • somo

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • somo

@Defelo Defelo merged commit 7e026d0 into NixOS:master Jul 9, 2025
26 of 30 checks passed
@kachick
Copy link
Member Author

kachick commented Jul 9, 2025

Thank you for reviewing and merging 🙏

@kachick kachick deleted the init-somo branch July 9, 2025 16:08
@kachick kachick mentioned this pull request Jul 12, 2025
Closed
@kachick kachick mentioned this pull request Aug 3, 2025
Merged
13 tasks
@kachick kachick mentioned this pull request Nov 8, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Defelo Defelo Defelo approved these changes

+1 more reviewer

@Flokkq Flokkq Flokkq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kachick @Flokkq @Defelo