-
-
Notifications
You must be signed in to change notification settings - Fork 17.3k
protonplus: 0.5.8 -> 0.5.9 #425112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protonplus: 0.5.8 -> 0.5.9 #425112
Conversation
Thanks. I wonder whether a passthru version test would have caught that - does that use |
|
Tested. This would work in principle: But: meh... |
I don't have any Vala experience unfortunately, otherwise I'd be happy to open an upstream PR for a version parameter. |
|
They came up with a much more reasonable binary name now than before... let's hope they won't change it anymore ;) |
wolfgangwalther
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 425112
Commit: 0ac4a7d07e1f5d19631beecae598032bae472104
x86_64-linux
✅ 1 package built:
- protonplus
aarch64-linux
✅ 1 package built:
- protonplus
|
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-425112-to-release-25.05 origin/release-25.05
cd .worktree/backport-425112-to-release-25.05
git switch --create backport-425112-to-release-25.05
git cherry-pick -x 0dd874f69a016f1cb2a86279f477f0fc7652679b 0ac4a7d07e1f5d19631beecae598032bae472104 |
Changelog: https://github.com/Vysp3r/ProtonPlus/releases/tag/v0.5.9
Also fixed
meta.mainProgramas the binary name changed in #419362Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.