Skip to content

Conversation

@niklaskorz
Copy link
Contributor

Changelog: https://github.com/Vysp3r/ProtonPlus/releases/tag/v0.5.9

Also fixed meta.mainProgram as the binary name changed in #419362

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 14, 2025
@nix-owners nix-owners bot requested a review from getchoo July 14, 2025 14:31
@wolfgangwalther
Copy link
Contributor

Also fixed meta.mainProgram as the binary name changed in #419362

Thanks. I wonder whether a passthru version test would have caught that - does that use meta.mainProgram by default?

@niklaskorz
Copy link
Contributor Author

niklaskorz commented Jul 14, 2025

Also fixed meta.mainProgram as the binary name changed in #419362

Thanks. I wonder whether a passthru version test would have caught that - does that use meta.mainProgram by default?

Funny you should ask (as in, good timing^^), #412768 landed in master yesterday :D

@wolfgangwalther
Copy link
Contributor

Tested. This would work in principle:

    tests.version = testers.testVersion {
      package = finalAttrs.finalPackage;
    };

But:

protonplus --version returned a non-zero exit code.
Unknown option --version

meh...

@niklaskorz
Copy link
Contributor Author

Tested. This would work in principle:

    tests.version = testers.testVersion {
      package = finalAttrs.finalPackage;
    };

But:

protonplus --version returned a non-zero exit code.
Unknown option --version

meh...

I don't have any Vala experience unfortunately, otherwise I'd be happy to open an upstream PR for a version parameter.

@wolfgangwalther
Copy link
Contributor

They came up with a much more reasonable binary name now than before... let's hope they won't change it anymore ;)

Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425112
Commit: 0ac4a7d07e1f5d19631beecae598032bae472104


x86_64-linux

✅ 1 package built:
  • protonplus

aarch64-linux

✅ 1 package built:
  • protonplus

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 14, 2025
@DieracDelta
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 425112
Commit: 0ac4a7d07e1f5d19631beecae598032bae472104


x86_64-linux

✅ 1 package built:
  • protonplus

aarch64-linux

✅ 1 package built:
  • protonplus

@wolfgangwalther wolfgangwalther merged commit 9fcd4ec into NixOS:master Jul 14, 2025
27 of 31 checks passed
@eclairevoyant eclairevoyant added the backport release-25.05 Backport PR automatically label Nov 5, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 5, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-425112-to-release-25.05 origin/release-25.05
cd .worktree/backport-425112-to-release-25.05
git switch --create backport-425112-to-release-25.05
git cherry-pick -x 0dd874f69a016f1cb2a86279f477f0fc7652679b 0ac4a7d07e1f5d19631beecae598032bae472104

@eclairevoyant eclairevoyant mentioned this pull request Nov 5, 2025
3 tasks
@niklaskorz niklaskorz deleted the protonplus-0.5.9 branch November 10, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. backport release-25.05 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants