various: migrate fetchPnpmDeps from fetcherVersion = 1 to fetcherVersion = 3 (part 4)#494402
Merged
Merged
Conversation
15 tasks
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
Contributor
Author
|
nixpkgs-ci
Bot
added
2.status: merge conflict
qweered
force-pushed
the
fetcherVersion-3-migration-part4
branch
from
03e0882 to
9350cef
Compare
nixpkgs-ci
Bot
added
10.rebuild-darwin: 1-10
qweered
force-pushed
the
fetcherVersion-3-migration-part4
branch
from
9350cef to
4599f37
Compare
nixpkgs-ci
Bot
added
10.rebuild-darwin: 11-100
Contributor
Author
|
Tested on x86_64, no errrors |
nixpkgs-ci
Bot
added
the
9.needs: reviewer
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
10 tasks
qweered
added a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 24, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used, gated by `lib.oldestSupportedReleaseIsAtLeast 2611` so the deprecation message only becomes visible once 26.11 is the oldest supported release (i.e., the next LTS to EOL). At that point, `supportedFetcherVersions` should drop 1 and the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix can be cleaned up. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history.
qweered
added a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 24, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used, gated by `lib.oldestSupportedReleaseIsAtLeast 2605` so the deprecation message activates once 26.05 becomes the oldest supported release (~Jun 2026, when 25.11 EOLs). That gives users roughly one release cycle of advance notice before v1 is removed in 26.11. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history.
2 tasks
qweered
added a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 24, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used, gated by `lib.oldestSupportedReleaseIsAtLeast 2605` so the deprecation message activates once 26.05 becomes the oldest supported release (~Jun 2026, when 25.11 EOLs). That gives users roughly one release cycle of advance notice before v1 is removed in 26.11. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history.
Contributor
|
gepbird
approved these changes
Apr 25, 2026
gepbird
left a comment
gepbird
left a comment
Contributor
There was a problem hiding this comment.
Thanks for coming back to this :)
Member
|
Member
|
Oh I am late |
Scrumplex
pushed a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 26, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
pushed a commit
to qweered/nixpkgs
that referenced
this pull request
Apr 26, 2026
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Most of them have; the remainder are being cleared in NixOS#494402 and NixOS#513204. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate various packages using
fetchPnpmDepsfromfetcherVersion = 1tofetcherVersion = 3and update their hashes accordingly.fetcherVersion = 1is deprecated and will be removed. Version 3 uses a more robust fetching strategy.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.