Conversation
|
35ce73e to
8945ca6
Compare
|
There was a problem hiding this comment.
👍 Thanks for that PR (and sorry for not being super active updating appflowy). The app runs and builds nearly flawlessly.
The thing is that as for the previous releases, the audio embed is still broken, and I have mixed feelings about landing an update that doesn't fully work (even though I acknowledge it's been a while since appflowy has been updated in nixpkgs) 🫤. Moreover, the code on their repo has not been updated since roughly the end of Q4 2025, so I'm not sure if we can still maintain the current licence in the meta section of the package 🤷...
Lastly it would be better to just import libgbm instead of mesa. It is true that mesa contains libgbm, but it's a bit overkill.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 497646
Commit: 8945ca62f02ae344410f951cefe423d5d4b519c3
x86_64-linux
✅ 2 packages built:
- appflowy
- nixpkgs-manual
thanks, updated |
Diff: AppFlowy-IO/AppFlowy@0.10.6...0.11.4 Changelog: https://github.com/AppFlowy-IO/appflowy/releases/tag/0.11.4 Signed-off-by: Dan Xin <davinci42.cn@gmail.com>
|
DarkOnion0
left a comment
There was a problem hiding this comment.
Builds and runs fine, LGTM 👍 ! However, I will try to find information on what to do about the issues I mentioned earlier before going any further...
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 497646
Commit: 1f318f843fa00556fdd05e2b8f0cfb2c676e7e37
x86_64-linux
✅ 2 packages built:
- appflowy
- nixpkgs-manual
Diff: AppFlowy-IO/AppFlowy@0.10.6...0.11.3
Changelog: https://github.com/AppFlowy-IO/appflowy/releases/tag/0.11.3
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.