Skip to content

nixos/gitea: Generate a JWT secret for git LFS - #63101

Merged
aanderse merged 1 commit into
NixOS:masterfrom
dasJ:gitea-jwt
Jun 27, 2019
Merged

nixos/gitea: Generate a JWT secret for git LFS#63101
aanderse merged 1 commit into
NixOS:masterfrom
dasJ:gitea-jwt

Conversation

@dasJ

@dasJ dasJ commented Jun 13, 2019

Copy link
Copy Markdown
Member
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 13, 2019
@aanderse aanderse mentioned this pull request Jun 17, 2019
Open
@aanderse

aanderse commented Jun 17, 2019

Copy link
Copy Markdown
Member

@dasJ it looks like we should use this instead. Bonus points awarded if you modify the existing secrets to use this method as well.

@dasJ

dasJ commented Jun 27, 2019

Copy link
Copy Markdown
Member Author

@aanderse Done. I hope I get all bonus points :)

@aanderse

aanderse commented Jun 27, 2019

Copy link
Copy Markdown
Member

@dasJ full bonus points awarded! You're awesome. Thanks for fixing that 😄

@GrahamcOfBorg build nixosTests.gitea

@aanderse
aanderse merged commit fa01a22 into NixOS:master Jun 27, 2019
@dasJ
dasJ deleted the gitea-jwt branch June 27, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dasJ @aanderse