Skip to content

Commit 5766ecd

Browse files
chinmaygardeNoamDev
authored andcommitted
Move tonic into //flutter/third_party. (flutter#15895)
Tonic used to be used by multiple consumers outside of Flutter Engine. Due to this, it has an unnecessary abstraction layer as well as utilities duplicated in FML and other engine subsystems. The sole user of Tonic is now the Flutter Engine. It is intended that the Flutter Engine team now owns this subsystem, remove unnecessary utilities and document the headers. This is the first step in the transition. No history is being imported as the initial history was already lost in the transition of this component to fuchsia.googlesource. As this component was unmaintained there, I could see no additional value in importing the history of the patches there. No functional change. Just moved the repo from //third_party to //flutter/third_party and updates GN refs.
1 parent 21ea450 commit 5766ecd

File tree

101 files changed

+5202
-400
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

101 files changed

+5202
-400
lines changed

DEPS

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,6 @@ deps = {
145145
# build. Eventually, we'll manage these dependencies together with Fuchsia
146146
# and not have to specific specific hashes.
147147

148-
'src/third_party/tonic':
149-
Var('fuchsia_git') + '/tonic' + '@' + '1a8ed9be2e2b56b32e888266d6db465d36012df4',
150-
151148
'src/third_party/benchmark':
152149
Var('fuchsia_git') + '/third_party/benchmark' + '@' + 'a779ffce872b4c811beef482e18bd0b63626aa42',
153150

ci/licenses_golden/licenses_flutter

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ USED LICENSES:
66

77
====================================================================================================
88
LIBRARY: engine
9+
LIBRARY: tonic
910
LIBRARY: txt
1011
ORIGIN: ../../../flutter/LICENSE
1112
TYPE: LicenseType.bsd
@@ -1122,6 +1123,66 @@ FILE: ../../../flutter/shell/version/version.cc
11221123
FILE: ../../../flutter/shell/version/version.h
11231124
FILE: ../../../flutter/sky/packages/flutter_services/lib/empty.dart
11241125
FILE: ../../../flutter/sky/tools/roll/patches/chromium/android_build.patch
1126+
FILE: ../../../flutter/third_party/tonic/common/build_config.h
1127+
FILE: ../../../flutter/third_party/tonic/common/log.cc
1128+
FILE: ../../../flutter/third_party/tonic/common/log.h
1129+
FILE: ../../../flutter/third_party/tonic/common/macros.h
1130+
FILE: ../../../flutter/third_party/tonic/converter/dart_converter.cc
1131+
FILE: ../../../flutter/third_party/tonic/converter/dart_converter.h
1132+
FILE: ../../../flutter/third_party/tonic/dart_args.h
1133+
FILE: ../../../flutter/third_party/tonic/dart_binding_macros.h
1134+
FILE: ../../../flutter/third_party/tonic/dart_class_library.cc
1135+
FILE: ../../../flutter/third_party/tonic/dart_class_library.h
1136+
FILE: ../../../flutter/third_party/tonic/dart_class_provider.cc
1137+
FILE: ../../../flutter/third_party/tonic/dart_class_provider.h
1138+
FILE: ../../../flutter/third_party/tonic/dart_library_natives.cc
1139+
FILE: ../../../flutter/third_party/tonic/dart_library_natives.h
1140+
FILE: ../../../flutter/third_party/tonic/dart_list.cc
1141+
FILE: ../../../flutter/third_party/tonic/dart_list.h
1142+
FILE: ../../../flutter/third_party/tonic/dart_message_handler.cc
1143+
FILE: ../../../flutter/third_party/tonic/dart_message_handler.h
1144+
FILE: ../../../flutter/third_party/tonic/dart_microtask_queue.cc
1145+
FILE: ../../../flutter/third_party/tonic/dart_microtask_queue.h
1146+
FILE: ../../../flutter/third_party/tonic/dart_persistent_value.cc
1147+
FILE: ../../../flutter/third_party/tonic/dart_persistent_value.h
1148+
FILE: ../../../flutter/third_party/tonic/dart_state.cc
1149+
FILE: ../../../flutter/third_party/tonic/dart_state.h
1150+
FILE: ../../../flutter/third_party/tonic/dart_wrappable.cc
1151+
FILE: ../../../flutter/third_party/tonic/dart_wrappable.h
1152+
FILE: ../../../flutter/third_party/tonic/dart_wrapper_info.h
1153+
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader.cc
1154+
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader.h
1155+
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader_fuchsia.cc
1156+
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader_posix.cc
1157+
FILE: ../../../flutter/third_party/tonic/file_loader/file_loader_win.cc
1158+
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/eintr_wrapper.h
1159+
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/file.cc
1160+
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/file.h
1161+
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/path.h
1162+
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/path_posix.cc
1163+
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/path_win.cc
1164+
FILE: ../../../flutter/third_party/tonic/filesystem/filesystem/portable_unistd.h
1165+
FILE: ../../../flutter/third_party/tonic/logging/dart_error.cc
1166+
FILE: ../../../flutter/third_party/tonic/logging/dart_error.h
1167+
FILE: ../../../flutter/third_party/tonic/logging/dart_invoke.cc
1168+
FILE: ../../../flutter/third_party/tonic/logging/dart_invoke.h
1169+
FILE: ../../../flutter/third_party/tonic/parsers/packages_map.cc
1170+
FILE: ../../../flutter/third_party/tonic/parsers/packages_map.h
1171+
FILE: ../../../flutter/third_party/tonic/platform/platform_utils.h
1172+
FILE: ../../../flutter/third_party/tonic/platform/platform_utils_posix.cc
1173+
FILE: ../../../flutter/third_party/tonic/platform/platform_utils_win.cc
1174+
FILE: ../../../flutter/third_party/tonic/scopes/dart_api_scope.h
1175+
FILE: ../../../flutter/third_party/tonic/scopes/dart_isolate_scope.cc
1176+
FILE: ../../../flutter/third_party/tonic/scopes/dart_isolate_scope.h
1177+
FILE: ../../../flutter/third_party/tonic/typed_data/dart_byte_data.cc
1178+
FILE: ../../../flutter/third_party/tonic/typed_data/dart_byte_data.h
1179+
FILE: ../../../flutter/third_party/tonic/typed_data/float32_list.h
1180+
FILE: ../../../flutter/third_party/tonic/typed_data/float64_list.h
1181+
FILE: ../../../flutter/third_party/tonic/typed_data/int32_list.h
1182+
FILE: ../../../flutter/third_party/tonic/typed_data/typed_list.cc
1183+
FILE: ../../../flutter/third_party/tonic/typed_data/typed_list.h
1184+
FILE: ../../../flutter/third_party/tonic/typed_data/uint16_list.h
1185+
FILE: ../../../flutter/third_party/tonic/typed_data/uint8_list.h
11251186
FILE: ../../../flutter/third_party/txt/src/txt/platform.cc
11261187
FILE: ../../../flutter/third_party/txt/src/txt/platform.h
11271188
FILE: ../../../flutter/third_party/txt/src/txt/platform_android.cc

0 commit comments

Comments
 (0)