This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move tonic into //flutter/third_party. #15895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jan 22, 2020
chinmaygarde
force-pushed
the
tonic_is_mine
branch
4 times, most recently
from
89a284b to
7009566
Compare
Tonic used to be used by multiple consumers outside of Flutter Engine. Due to this, it has an unnecessary abstraction layer as well as utilities duplicated in FML and other engine subsystems. The sole user of Tonic is now the Flutter Engine. It is intended that the Flutter Engine team now owns this subsystem, remove unnecessary utilities and document the headers. This is the first step in the transition. No history is being imported as the initial history was already lost in the transition of this component to fuchsia.googlesource. As this component was unmaintained there, I could see no additional value in importing the history of the patches there. No functional change. Just moved the repo from //third_party to //flutter/third_party and updates GN refs.
chinmaygarde
force-pushed
the
tonic_is_mine
branch
from
87050fe to
ead6ddb
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2020
…#49493) flutter/engine@6fa1fcd...276481c git log 6fa1fcd..276481c --first-parent --oneline 2020-01-26 [email protected] Move tonic into //flutter/third_party. (flutter/engine#15895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
cbracken
added a commit
that referenced
this pull request
Jan 30, 2020
stuartmorgan-g
pushed a commit
to stuartmorgan-g/engine
that referenced
this pull request
Jan 30, 2020
Looks like this was triggered by the recent tonic deletion. Related commits: * Move tonic into //flutter/third_party. flutter#15895 * Remove tonic/platform. flutter#16062 This is preventing the Dart roller from rolling.
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
Tonic used to be used by multiple consumers outside of Flutter Engine. Due to this, it has an unnecessary abstraction layer as well as utilities duplicated in FML and other engine subsystems. The sole user of Tonic is now the Flutter Engine. It is intended that the Flutter Engine team now owns this subsystem, remove unnecessary utilities and document the headers. This is the first step in the transition. No history is being imported as the initial history was already lost in the transition of this component to fuchsia.googlesource. As this component was unmaintained there, I could see no additional value in importing the history of the patches there. No functional change. Just moved the repo from //third_party to //flutter/third_party and updates GN refs.
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
Looks like this was triggered by the recent tonic deletion. Related commits: * Move tonic into //flutter/third_party. flutter#15895 * Remove tonic/platform. flutter#16062 This is preventing the Dart roller from rolling.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit 5766ecd.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tonic used to be used by multiple consumers outside of Flutter Engine. Due to this, it has an unnecessary abstraction layer as well as utilities duplicated in FML and other engine subsystems. The sole user of Tonic is now the Flutter Engine. It is intended that the Flutter Engine team now owns this subsystem, removes unnecessary utilities and documents the headers. This is the first step in the transition. No history is being imported as the initial history was already lost in the transition of this component to fuchsia.googlesource. As this component was unmaintained there, I could see no additional value in importing the history of the patches there.
No functional change. Just moved the repo from //third_party to //flutter/third_party and updates GN refs.