fix: broken morse detection #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #144
The stringCharDiversity was breaking the test (and the analysis), in the
morse.jsfixture, we have somethings like:’.-‘: ‘a’,-> here, stringCharDiversity is 2’-…’: ‘b’,-> stringCharDiversity is 2’-.-.’: ‘c’,-> stringCharDiversity is 2’-..’: ‘d’,->stringCharDiversity is 2’.’: ‘e’,-> stringCharDiversity is 1’..-.’: ‘f’,-> stringCharDiversity is 2Actually the total counter of morseLiteral in the
morse.jsfixture is 37, which match:That’s why I think this fix is fine.
I’ve also added a "not morse" detection test, I’m not sure about this test plus-value and the fixture’s accuracy but it should test there is no abuse with theses changes.