Repository navigation
Web: update livekit-client to 2.24.0 - #18
Merged
Merged
Conversation
npm gives every file in its packages the same 1985 timestamp, and SCons reuses a stored content signature for a file older than two days whose timestamp hasn't changed. So after a version change, ./build.sh web downloaded the new livekit-client but kept embedding the old one. Extracting with -m gives the files the current time instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It fixes livekit/client-sdk-js#2187: a receiver that got data, but no media, from a sender couldn't decrypt that sender's data once it ratcheted its key. The web differences doc no longer lists it, and a new test covers it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the SDK update and accompanying build and encryption-test changes.
No open issues 🎉
What changed in this PR
Updates the web build’s embedded livekit-client to 2.24.0, fixes stale SDK embedding during incremental builds, and adds coverage for data-only encrypted receivers following key ratchets.
Changes:
- Updates the SDK version and checksum.
- Extracts SDK files with current timestamps so SCons detects version changes.
- Adds a data-only key-ratchet regression test and removes the resolved limitation from the web documentation.
| File | Description |
|---|---|
test/e2e/test_e2ee.gd |
Tests encrypted data delivery before and after a sender’s key ratchet, without media. |
src/web/README.md |
Updates the SDK version and removes the data-only ratchet limitation. |
build.sh |
Updates the SDK pin and checksum, and fixes extraction timestamps for incremental builds. |
Review effort: Balanced
mdepinet
added a commit
to avinoamn/godot-livekit
that referenced
this pull request
Nov 16, 2026
NodotProject#18's new data-only ratchet test called _skip_if_unsupported(), which this branch replaced with per-test checks, so it uses _skip_if_no_server() now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the web build's embedded livekit-client from 2.22.3 to 2.24.0, and fixes a build bug the update exposed.
livekit-client 2.24.0
src/web/README.mdno longer lists this as a web difference. New test:test_data_only_receiver_follows_a_ratcheted_key. It fails on 2.22.3 (the data sent after the ratchet never arrives) and passes on 2.24.0. Natively, it's pending like the other E2EE tests.RoomintoCoreRoomplus extensions, but the UMD build we embed still includes everything, and nothing inbridge.jsneeded to change. The license is still Apache-2.0.Build fix
After a livekit-client version change,
./build.sh webin an existing checkout downloaded the new version but kept embedding the old one. npm gives every file in its packages the same 1985 timestamp, and SCons reuses a file's stored content signature when the file is over two days old and its timestamp hasn't changed.build.shnow extracts livekit-client withtar -m, so its files get the current time. CI wasn't affected, since its cache key includesbuild.sh. To check the fix, I switched an existing checkout between 2.22.3 and 2.24.0 in both directions, and each build embedded the right version.Testing
./test_web.sh, with the integration and e2e tests againstlivekit-server --dev, runs 207 tests: all pass, and one is pending (monitor capture).🤖 Generated with Claude Code