-
Notifications
You must be signed in to change notification settings - Fork 2
feat!: forward expose/emits form NuxtUI Form
#18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I am not huge fan of changing the AutoForn component, I tried to make it have the best DX out of the box, so you can avoid code duplication with things like changing variant of the submit button. But I see that in some use cases you want to have something identical to @nuxt/ui's version and I think the best solution would be to create a new component (primitive auto form), that will be used inside original |
|
It can be a solution, but I don't really understand why you are not a fan of changing the |
|
It isn’t about introducing a breaking change. That’s why:
Many form use cases are similar, so it makes sense to build an abstraction around them. The current approach uses an Since the Nuxt UI forms system isn’t perfect, this module aims to serve two groups of developers: those who want higher-level abstractions with sensible defaults and those who just want a drop-in replacement for @nuxt/ui forms, without extra features (like you). It won't be hard to maintain and it would resolve probably use cases, so I don't see any downsides of my solution |
|
Thanks for the explanation. I now understand your view and agree with it, I'll try to move the changes I made to another component, how would you like to call it? |
|
I am not sure... Currently all the components start with letter "A", so maybe After some consideration I think |
|
I was more on the |
|
I'll create a pool on an undisclosed Discord server with some Nuxters, so we can ask more people for opinion :3 For now you can use either of those names |
In my opinion it is better to align with the NuxtUI
Formcomponent emits and exposed methods for better compatibility. Hope it helps.Closes #15