Skip to content

Add Design Review notifications and dont necessitate receipts on RR form#2730

Merged
Peyton-McKee merged 2 commits intodevelopfrom
Design-Review-Notifications
Jul 23, 2024
Merged

Add Design Review notifications and dont necessitate receipts on RR form#2730
Peyton-McKee merged 2 commits intodevelopfrom
Design-Review-Notifications

Conversation

@Peyton-McKee
Copy link
Copy Markdown
Contributor

Changes

Added a section to the ntoification endpoint that also sounds out notifications for design reviews that are scheduled for that day.

No longer necessitate one receipt being added to a reimbursement request

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@Peyton-McKee Peyton-McKee requested a review from walker-sean July 23, 2024 02:41
@Peyton-McKee Peyton-McKee self-assigned this Jul 23, 2024
@Peyton-McKee Peyton-McKee merged commit d54e7b6 into develop Jul 23, 2024
@Peyton-McKee Peyton-McKee deleted the Design-Review-Notifications branch July 23, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant