2707 recruitment deletemilestone endpoint#2751
Merged
walker-sean merged 20 commits intodevelopfrom Aug 12, 2024
Merged
Conversation
Aaryan1203
requested changes
Aug 8, 2024
Contributor
Aaryan1203
left a comment
Aaryan1203
left a comment
There was a problem hiding this comment.
Great job! your tests look rlly good. Just a couple things and then it looks good for me
Peyton-McKee
requested changes
Aug 9, 2024
Aaryan1203
requested changes
Aug 11, 2024
Contributor
Aaryan1203
left a comment
Aaryan1203
left a comment
There was a problem hiding this comment.
couple comments but rlly nice job
walker-sean
requested changes
Aug 12, 2024
Member
walker-sean
left a comment
walker-sean
left a comment
There was a problem hiding this comment.
Quick comment + merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Deletes a milestone based on the milestone id and organization id
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #2707