Skip to content

Created validate organizationid helper function and fixed endpoint#2755

Merged
Peyton-McKee merged 23 commits intodevelopfrom
validate-organizationid-helper
Aug 28, 2024
Merged

Created validate organizationid helper function and fixed endpoint#2755
Peyton-McKee merged 23 commits intodevelopfrom
validate-organizationid-helper

Conversation

@Aaryan1203
Copy link
Copy Markdown
Contributor

Changes

Created validateOrganizationId helper method to reduce repeated code

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #

@Aaryan1203 Aaryan1203 self-assigned this Aug 12, 2024
Peyton-McKee
Peyton-McKee previously approved these changes Aug 24, 2024
Copy link
Copy Markdown
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fix Merge Conflicts and Ill merge

},
"exclude": ["node_modules", "dist"],
"include": ["./index.ts", "./src/**/*.ts"]
"include": ["./index.ts", "./src/**/*.ts", "../frontend/src/**/*.ts", "./src/types"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change necessary

Copy link
Copy Markdown
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peyton-McKee Peyton-McKee merged commit d567843 into develop Aug 28, 2024
@Peyton-McKee Peyton-McKee deleted the validate-organizationid-helper branch August 28, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants