#2656: Fixed Settings page to show which team your in even when you have leadership role#3175
Merged
walker-sean merged 5 commits intodevelopfrom Feb 23, 2025
Merged
Conversation
Contributor
|
LGTM! Great work! I'll ask sean to take a look at it once the issue with the tests is resolved |
vsp05
previously approved these changes
Feb 6, 2025
Contributor
vsp05
left a comment
vsp05
left a comment
There was a problem hiding this comment.
great work! @walker-sean could you take a look when you get a chance?
walker-sean
requested changes
Feb 6, 2025
|
|
||
| const userTeams = teams.filter((team) => | ||
| team.members.some((member) => member.userId === user.userId || team.head.userId === user.userId) | ||
| team.members.some( |
Member
There was a problem hiding this comment.
The some calls its given callback for each item in the array, so we're potentially doing a lot of unnecessary checks here. Let's do it serially, checking if the user is in the team, then if the user is a lead, then if the user is the head.
Contributor
There was a problem hiding this comment.
im pretty sure we have a userOnTeam function already that can be used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed Settings page to show which team your in even when you have leadership role
Notes
Any other notes go here
Test Cases
Screenshots
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #2656