#3194 getSponsorTasks endpoint#3269
Merged
walker-sean merged 21 commits intofeature/finance-redesignfrom Mar 25, 2025
Merged
Conversation
dreifusjack
requested changes
Mar 3, 2025
Contributor
dreifusjack
left a comment
dreifusjack
left a comment
There was a problem hiding this comment.
Sorry the description of this ticket was a little ambiguous. The service should take a sponsorId as a parameter, so you'll have to update the route and controller as well. Then in the service you can findUnique sponsor using the the id and you shouldn't be getting those errors. Also the errors were coming from you were trying to find a unique sponsor using an org id but there could be multiple sponsors with the same org id.
dreifusjack
reviewed
Mar 8, 2025
Contributor
dreifusjack
left a comment
dreifusjack
left a comment
There was a problem hiding this comment.
just left a small comment, other than that looks good!
dreifusjack
changed the title
walker-sean
requested changes
Mar 11, 2025
Member
walker-sean
left a comment
walker-sean
left a comment
There was a problem hiding this comment.
Manual and unit tests please
dreifusjack
requested changes
Mar 20, 2025
Contributor
dreifusjack
left a comment
dreifusjack
left a comment
There was a problem hiding this comment.
just some small changes
walker-sean
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
added the controller, service, transformer, and other things to create the endpoint.
Tests
Checklist
yarn.lockchanges (unless dependencies have changed)Closes #3194