#3287 Parts Review Submission Guide#3288
Merged
walker-sean merged 4 commits intofeature/cad-project-file-reviewfrom Mar 15, 2025
Merged
#3287 Parts Review Submission Guide#3288walker-sean merged 4 commits intofeature/cad-project-file-reviewfrom
walker-sean merged 4 commits intofeature/cad-project-file-reviewfrom
Conversation
chpy04
requested changes
Mar 10, 2025
| import { useCurrentUser } from '../../../../hooks/users.hooks'; | ||
| import { rankUserRole } from 'shared'; | ||
|
|
||
| const NERSwitch = styled((props: SwitchProps) => ( |
Contributor
There was a problem hiding this comment.
Can we add this to the components folder? Seems like a general enough thing that it should be available past this one page
Contributor
Author
There was a problem hiding this comment.
Sure thing -- I had just grabbed it from the settings page (it's used for trickster mode lol), I can make it a component
| return <LoadingIndicator />; | ||
| const currentUser = useCurrentUser(); | ||
| const [showSubmissionGuide, setShowSubmissionGuide] = useState(() => { | ||
| if (!currentUser) return false; |
walker-sean
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Created the Submission Guide section of the Parts Review tab for Projects, toggleable via slider and with default toggle based on user role.
Screenshots
App Admin, Admin, and Leadership default view:
Member and Guest default view:
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3287