Skip to content

added create sponsorTier endpoint#3307

Merged
dreifusjack merged 3 commits intofeature/finance-redesignfrom
#3295-create-sponsortier
Mar 19, 2025
Merged

added create sponsorTier endpoint#3307
dreifusjack merged 3 commits intofeature/finance-redesignfrom
#3295-create-sponsortier

Conversation

@nickyokaitis
Copy link
Copy Markdown
Contributor

@nickyokaitis nickyokaitis commented Mar 18, 2025

Changes

Added a create sponsor tier endpoint.

Test Cases

  • Succeeds and creates a sponsor tier
  • Fails if a user is not a head

Screenshots

Screenshot 2025-03-19 110942

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3295

@nickyokaitis nickyokaitis self-assigned this Mar 18, 2025
Copy link
Copy Markdown
Contributor

@dreifusjack dreifusjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just added a small comment

financeRouter.delete('/sponsor/:sponsorId/delete', FinanceController.deleteSponsor);

financeRouter.post(
'/sponsortier/create',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to 'sponsorTier'

Copy link
Copy Markdown
Contributor

@dreifusjack dreifusjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dreifusjack dreifusjack merged commit 72fe561 into feature/finance-redesign Mar 19, 2025
4 checks passed
@dreifusjack dreifusjack deleted the #3295-create-sponsortier branch March 19, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants