3211 finance menu tabs should be legible in light mode#3312
Merged
walker-sean merged 5 commits intodevelopfrom Apr 30, 2025
Merged
3211 finance menu tabs should be legible in light mode#3312walker-sean merged 5 commits intodevelopfrom
walker-sean merged 5 commits intodevelopfrom
Conversation
vsp05
previously approved these changes
Mar 19, 2025
jonathan-chen10
requested changes
Mar 21, 2025
Contributor
jonathan-chen10
left a comment
There was a problem hiding this comment.
Nice job integrating the theme, recommended a fix
jonathan-chen10
approved these changes
Apr 27, 2025
Contributor
jonathan-chen10
left a comment
There was a problem hiding this comment.
Still not the best gray color but much better than before! Approved
vsp05
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This pull request includes updates to the
Tabscomponent in thesrc/frontend/src/components/Tabs.tsxfile to enhance its theming capabilities and adjust the appearance based on thegreyscaleprop.Theme integration and appearance adjustments:
src/frontend/src/components/Tabs.tsx: AddeduseThemefrom@mui/materialto allow access to the theme object within the component.const Tabs = ({insrc/frontend/src/components/Tabs.tsx: Initialized thethemevariable usinguseThemeto utilize the theme properties.const Tabs = ({insrc/frontend/src/components/Tabs.tsx: Changed thetextColorproperty to use 'secondary' whengreyscaleis true for better visual distinction.const Tabs = ({insrc/frontend/src/components/Tabs.tsx: Updated thesxprop to conditionally set thecolorbased on thegreyscaleprop, using the theme'stext.primarycolor.yarn.lockchanges (unless dependencies have changed)Closes # (issue #)
#3211