Skip to content

3211 finance menu tabs should be legible in light mode#3312

Merged
walker-sean merged 5 commits intodevelopfrom
3211-finance-menu---tabs-should-be-legible-in-light-mode
Apr 30, 2025
Merged

3211 finance menu tabs should be legible in light mode#3312
walker-sean merged 5 commits intodevelopfrom
3211-finance-menu---tabs-should-be-legible-in-light-mode

Conversation

@thaninbew
Copy link
Copy Markdown
Contributor

@thaninbew thaninbew commented Mar 19, 2025

Changes

This pull request includes updates to the Tabs component in the src/frontend/src/components/Tabs.tsx file to enhance its theming capabilities and adjust the appearance based on the greyscale prop.

Theme integration and appearance adjustments:

  • src/frontend/src/components/Tabs.tsx: Added useTheme from @mui/material to allow access to the theme object within the component.
  • const Tabs = ({ in src/frontend/src/components/Tabs.tsx: Initialized the theme variable using useTheme to utilize the theme properties.
  • const Tabs = ({ in src/frontend/src/components/Tabs.tsx: Changed the textColor property to use 'secondary' when greyscale is true for better visual distinction.
  • const Tabs = ({ in src/frontend/src/components/Tabs.tsx: Updated the sx prop to conditionally set the color based on the greyscale prop, using the theme's text.primary color.
    image
  • [ x] All commits are tagged with the ticket number
  • [ x] No linting errors / newline at end of file warnings
  • [ x] All code follows repository-configured prettier formatting
  • [ x] No merge conflicts
  • [ x] All checks passing
  • [ x] Screenshots of UI changes (see Screenshots section)
  • [ x] Remove any non-applicable sections of this template
  • [ x] Assign the PR to yourself
  • [ x] No yarn.lock changes (unless dependencies have changed)
  • [ x] Request reviewers & ping on Slack
  • [ x] PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)
#3211

@thaninbew thaninbew self-assigned this Mar 19, 2025
@thaninbew thaninbew linked an issue Mar 19, 2025 that may be closed by this pull request
vsp05
vsp05 previously approved these changes Mar 19, 2025
Copy link
Copy Markdown
Contributor

@jonathan-chen10 jonathan-chen10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job integrating the theme, recommended a fix

Copy link
Copy Markdown
Contributor

@jonathan-chen10 jonathan-chen10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not the best gray color but much better than before! Approved

@vsp05 vsp05 self-requested a review April 29, 2025 04:20
@walker-sean walker-sean merged commit de035bc into develop Apr 30, 2025
4 checks passed
@walker-sean walker-sean deleted the 3211-finance-menu---tabs-should-be-legible-in-light-mode branch April 30, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finance Menu - Tabs Should Be Legible in Light Mode

4 participants