#3142 start of finance dashboard#3363
Merged
wavehassman merged 17 commits intofeature/finance-redesignfrom May 4, 2025
Merged
Conversation
dreifusjack
reviewed
Apr 28, 2025
src/frontend/src/pages/FinancePage/FinanceComponents/PieChart.tsx
Outdated
Show resolved
Hide resolved
dreifusjack
reviewed
Apr 28, 2025
src/frontend/src/pages/FinancePage/FinanceDashboard/FinanceDashboardAllView.tsx
Outdated
Show resolved
Hide resolved
dreifusjack
reviewed
Apr 28, 2025
src/frontend/src/pages/FinancePage/FinanceComponents/TitleBox.tsx
Outdated
Show resolved
Hide resolved
dreifusjack
reviewed
Apr 28, 2025
Contributor
There was a problem hiding this comment.
This looks great so far! Here are some things I noticed checking out this page on finishline:
- There is a scrollbar on the bottom of the Balance box which I think should be removed
- When all of the balance types are dropped down a vertical scrollbar appears that should be removed
- I noticed when there is no budget no pie chart is rendered, I think something should be rendered there to indicate no budget, either an empty pie chart or even something else. If you think its better how it is now you can totally leave it too
- Also I played around with the start and end dates and they are a little buggy when you click the button but not the calendar icon
- Would it be possible to have a min threshold on the amount a balance type can take up the pie chart. Bc checking it out on Thomas Emrax I can barely see the red line representing pending leadership
dreifusjack
reviewed
May 1, 2025
dreifusjack
reviewed
May 1, 2025
dreifusjack
reviewed
May 1, 2025
src/frontend/src/pages/FinancePage/FinanceComponents/PieChart.tsx
Outdated
Show resolved
Hide resolved
dreifusjack
reviewed
May 1, 2025
src/frontend/src/pages/FinancePage/FinanceDashboard/GeneralFinanceDashboard.tsx
Outdated
Show resolved
Hide resolved
dreifusjack
reviewed
May 1, 2025
dreifusjack
reviewed
May 1, 2025
walker-sean
requested changes
May 4, 2025
src/frontend/src/pages/FinancePage/FinanceComponents/PieChart.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceComponents/PieChart.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceComponents/PieChart.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceDashboard/AdminFinanceDashboard.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceDashboard/AdminFinanceDashboard.tsx
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceDashboard/AdminFinanceDashboard.tsx
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceDashboard/AdminFinanceDashboard.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceDashboard/AdminFinanceDashboard.tsx
Outdated
Show resolved
Hide resolved
walker-sean
requested changes
May 4, 2025
src/frontend/src/pages/FinancePage/FinanceComponents/PieChart.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/FinancePage/FinanceDashboard/AdminFinanceDashboard.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Finance dashboard has two different views, one for admins/finance where the tabs are each team type and one for heads/leads/members where the tabs are each team the user is on. Still need the spending bar component, modals and the special look of the pie chart for admin/finance, are other tickets.
Screenshots
Admin/finance

Everyone else

If on one team
If on multiple teams

ltiple
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)closes issue #3142