Skip to content

#3142 start of finance dashboard#3363

Merged
wavehassman merged 17 commits intofeature/finance-redesignfrom
#3142-pie-chart-component
May 4, 2025
Merged

#3142 start of finance dashboard#3363
wavehassman merged 17 commits intofeature/finance-redesignfrom
#3142-pie-chart-component

Conversation

@wavehassman
Copy link
Copy Markdown
Contributor

@wavehassman wavehassman commented Mar 31, 2025

Changes

Finance dashboard has two different views, one for admins/finance where the tabs are each team type and one for heads/leads/members where the tabs are each team the user is on. Still need the spending bar component, modals and the special look of the pie chart for admin/finance, are other tickets.

Screenshots

Admin/finance
Screenshot 2025-05-01 at 2 31 46 PM

Everyone else
If on one team
Screenshot 2025-05-01 at 2 41 45 PM

If on multiple teams
Screenshot 2025-05-01 at 3 31 12 PM
ltiple

Screenshot 2025-05-02 at 4 20 54 PM Screenshot 2025-05-02 at 4 10 43 PM Screenshot 2025-05-02 at 3 56 59 PM Screenshot 2025-05-02 at 4 07 36 PM Screenshot 2025-05-02 at 3 57 42 PM Screenshot 2025-05-02 at 3 55 46 PM Screenshot 2025-05-02 at 4 11 19 PM Screenshot 2025-05-02 at 3 56 25 PM Screenshot 2025-05-02 at 4 09 09 PM Screenshot 2025-05-02 at 3 58 11 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

closes issue #3142

@wavehassman wavehassman changed the base branch from develop to feature/finance-redesign March 31, 2025 00:19
@wavehassman wavehassman self-assigned this Mar 31, 2025
@wavehassman wavehassman marked this pull request as draft March 31, 2025 00:22
@wavehassman wavehassman changed the title #3142 pie chart component #3142 finance dashboard Apr 28, 2025
Copy link
Copy Markdown
Contributor

@dreifusjack dreifusjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far! Here are some things I noticed checking out this page on finishline:

  1. There is a scrollbar on the bottom of the Balance box which I think should be removed
  2. When all of the balance types are dropped down a vertical scrollbar appears that should be removed
  3. I noticed when there is no budget no pie chart is rendered, I think something should be rendered there to indicate no budget, either an empty pie chart or even something else. If you think its better how it is now you can totally leave it too
  4. Also I played around with the start and end dates and they are a little buggy when you click the button but not the calendar icon
  5. Would it be possible to have a min threshold on the amount a balance type can take up the pie chart. Bc checking it out on Thomas Emrax I can barely see the red line representing pending leadership

@wavehassman wavehassman changed the title #3142 finance dashboard #3142 start of finance dashboard May 2, 2025
@wavehassman wavehassman requested a review from walker-sean May 2, 2025 21:24
@wavehassman wavehassman marked this pull request as ready for review May 2, 2025 21:25
@wavehassman wavehassman requested a review from walker-sean May 4, 2025 17:07
@wavehassman wavehassman merged commit ebb95a1 into feature/finance-redesign May 4, 2025
4 checks passed
@wavehassman wavehassman deleted the #3142-pie-chart-component branch May 4, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants