Skip to content

#3380 reimbursement request comments endpoints#3382

Merged
dreifusjack merged 8 commits intofeature/finance-redesignfrom
#3380-reimbursement-request-comments-endpoints
Apr 8, 2025
Merged

#3380 reimbursement request comments endpoints#3382
dreifusjack merged 8 commits intofeature/finance-redesignfrom
#3380-reimbursement-request-comments-endpoints

Conversation

@dreifusjack
Copy link
Copy Markdown
Contributor

@dreifusjack dreifusjack commented Apr 5, 2025

Changes

  • modified the schema for RRComment to add a date deleted field and resolve a typo
  • createdRRComment endpoint
  • editRRComment endpoint
  • deleteRRComment endpoint
  • modified RR type, query args, and transformer to include its comments

Notes

When I read over the epic, it seemed like every user should have access to the RR Timeline so I haven't added any user constraints on the endpoints but lmk if I should

Screenshots

RR includes comments:
Screenshot 2025-04-05 at 9 02 50 PM

Creating RR comment:
Screenshot 2025-04-05 at 9 09 10 PM

Editing:
Screenshot 2025-04-05 at 9 10 23 PM

Deleting:
Screenshot 2025-04-05 at 9 22 49 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3380

@dreifusjack dreifusjack self-assigned this Apr 5, 2025
@dreifusjack dreifusjack removed the request for review from wavehassman April 8, 2025 12:13
@dreifusjack dreifusjack merged commit ce43bc5 into feature/finance-redesign Apr 8, 2025
4 checks passed
@dreifusjack dreifusjack deleted the #3380-reimbursement-request-comments-endpoints branch April 8, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants