#3380 reimbursement request comments endpoints#3382
Merged
dreifusjack merged 8 commits intofeature/finance-redesignfrom Apr 8, 2025
Merged
#3380 reimbursement request comments endpoints#3382dreifusjack merged 8 commits intofeature/finance-redesignfrom
dreifusjack merged 8 commits intofeature/finance-redesignfrom
Conversation
walker-sean
previously requested changes
Apr 8, 2025
src/backend/src/controllers/reimbursement-requests.controllers.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Notes
When I read over the epic, it seemed like every user should have access to the RR Timeline so I haven't added any user constraints on the endpoints but lmk if I should
Screenshots
RR includes comments:

Creating RR comment:

Editing:

Deleting:

Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3380