Skip to content

added lead and manager defaults for wps#3531

Merged
chpy04 merged 2 commits intodevelopfrom
lead-manager-changes
Aug 17, 2025
Merged

added lead and manager defaults for wps#3531
chpy04 merged 2 commits intodevelopfrom
lead-manager-changes

Conversation

@walker-sean
Copy link
Copy Markdown
Member

@walker-sean walker-sean commented Aug 17, 2025

Changes

Based on a product request:

  • made leads and managers for a WP default to that of the project when they are created
  • if a project gains a manager and/or lead after creation, any WP without a lead and/or manager will have them assigned to that of the project

Notes

I'm sure there are some optimizations that could be done in querying and/or updating, please lmk if you spot any

Test Cases

  • create WP with project and assign lead/manager
  • Create Project, create WP, assign lead/manager

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@walker-sean walker-sean requested a review from chpy04 August 17, 2025 02:54
@walker-sean walker-sean self-assigned this Aug 17, 2025
Copy link
Copy Markdown
Contributor

@chpy04 chpy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chpy04 chpy04 merged commit a60d2ac into develop Aug 17, 2025
4 checks passed
@chpy04 chpy04 deleted the lead-manager-changes branch August 17, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants