fix for Status node sends messages on device state change without input trigger #195#196
Merged
NorthernMan54 merged 5 commits intomainfrom Jan 23, 2026
Merged
fix for Status node sends messages on device state change without input trigger #195#196NorthernMan54 merged 5 commits intomainfrom
NorthernMan54 merged 5 commits intomainfrom
Conversation
Bumps the npm-dependencies group with 4 updates in the / directory: [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js), [eslint](https://github.com/eslint/eslint), [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) and [globals](https://github.com/sindresorhus/globals). Updates `@eslint/js` from 9.39.1 to 9.39.2 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](https://github.com/eslint/eslint/commits/v9.39.2/packages/js) Updates `eslint` from 9.39.1 to 9.39.2 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.1...v9.39.2) Updates `eslint-plugin-jest` from 29.2.1 to 29.12.0 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v29.2.1...v29.12.0) Updates `globals` from 16.5.0 to 17.0.0 - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v16.5.0...v17.0.0) --- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 9.39.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-dependencies - dependency-name: eslint dependency-version: 9.39.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-dependencies - dependency-name: eslint-plugin-jest dependency-version: 29.12.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-dependencies - dependency-name: globals dependency-version: 17.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #195 where the status node was incorrectly sending messages on device state changes without an input trigger. The fix restores the original behavior by commenting out the handleHBEventMessage method in the status node, directing users to use the event node instead for receiving all events.
Changes:
- Removed
handleHBEventMessagemethod from status node to prevent automatic event emission - Updated Node-RED test environment to version 4.1.2 with new configuration features
- Bumped package version to 0.3.3
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hbStatusNode.js | Commented out handleHBEventMessage method to fix unwanted event emissions |
| package.json | Version bump to 0.3.3, updated dependencies (Node-RED 4.1.2, globals 17.0.0), improved dev scripts |
| test/node-red/settings.js | Updated settings file for Node-RED 4.1.2 with telemetry config, globalFunctionTimeout, and formatting improvements |
| test/node-red/test/node-red/. | Removed runtime-generated configuration files |
| README.md | Added release notes for version 0.3.3 documenting the breaking change and fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| } | ||
|
|
||
| /* #194 - Removed - see event node |
There was a problem hiding this comment.
Owner
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Contributor
|
@NorthernMan54 I've opened a new pull request, #201, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Fix issue number in comment from #194 to #195 Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
NorthernMan54
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.