[codex] Standardize Hermes dotenv loading to shared env helper#13660
Closed
Bongulielmi wants to merge 1 commit into
Closed
[codex] Standardize Hermes dotenv loading to shared env helper#13660Bongulielmi wants to merge 1 commit into
Bongulielmi wants to merge 1 commit into
Conversation
alt-glitch
added
type/refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change standardizes Hermes dotenv loading by replacing three remaining ad hoc
dotenv.load_dotenvcall sites with the sharedhermes_cli.env_loader.load_hermes_dotenvhelper.The affected call sites are:
hermes_cli/doctor.pyhermes_cli/dump.pyscripts/discord-voice-doctor.pyThis keeps dotenv precedence logic in one place and removes duplicated fallback handling from those entry points.
Why
Before this patch, these files each implemented their own local
.envloading behavior while the repo already had a shared loader with the intended Hermes-home and project.envsemantics. That duplication made the behavior harder to keep aligned.Validation
python3 -m py_compile /Users/blucid/.hermes/hermes-agent/hermes_cli/doctor.py /Users/blucid/.hermes/hermes-agent/hermes_cli/dump.py /Users/blucid/.hermes/hermes-agent/scripts/discord-voice-doctor.pygit diff -- hermes_cli/doctor.py hermes_cli/dump.py scripts/discord-voice-doctor.pyrg -n "load_dotenv|load_hermes_dotenv" hermes_cli/doctor.py hermes_cli/dump.py scripts/discord-voice-doctor.pyRelated Linear issue: RGGB-22