-
Notifications
You must be signed in to change notification settings - Fork 22.7k
feat(curator): background skill maintenance (issue #7816) #16049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9dd59cb
feat(curator): background skill maintenance (issue #7816)
teknium1 f40ccec
refactor(curator): point review prompt at existing tools
teknium1 76df764
fix(curator): defense-in-depth gates against bundled/hub skills
teknium1 0be5145
fix(curator): default cycle is every 7 days, not 24 hours
teknium1 83b2263
feat(curator): hook into the gateway's cron-ticker thread
teknium1 13ca9ee
Merge remote-tracking branch 'origin/main' into hermes/curator-infra
teknium1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,221 @@ | ||
| """CLI subcommand: `hermes curator <subcommand>`. | ||
|
|
||
| Thin shell around agent/curator.py and tools/skill_usage.py. Renders a status | ||
| table, triggers a run, pauses/resumes, and pins/unpins skills. | ||
|
|
||
| This module intentionally has no side effects at import time — main.py wires | ||
| the argparse subparsers on demand. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import argparse | ||
| import sys | ||
| from datetime import datetime, timezone | ||
| from typing import Optional | ||
|
|
||
|
|
||
| def _fmt_ts(ts: Optional[str]) -> str: | ||
| if not ts: | ||
| return "never" | ||
| try: | ||
| dt = datetime.fromisoformat(ts) | ||
| except (TypeError, ValueError): | ||
| return str(ts) | ||
| if dt.tzinfo is None: | ||
| dt = dt.replace(tzinfo=timezone.utc) | ||
| delta = datetime.now(timezone.utc) - dt | ||
| secs = int(delta.total_seconds()) | ||
| if secs < 60: | ||
| return f"{secs}s ago" | ||
| if secs < 3600: | ||
| return f"{secs // 60}m ago" | ||
| if secs < 86400: | ||
| return f"{secs // 3600}h ago" | ||
| return f"{secs // 86400}d ago" | ||
|
|
||
|
|
||
| def _cmd_status(args) -> int: | ||
| from agent import curator | ||
| from tools import skill_usage | ||
|
|
||
| state = curator.load_state() | ||
| enabled = curator.is_enabled() | ||
| paused = state.get("paused", False) | ||
| last_run = state.get("last_run_at") | ||
| summary = state.get("last_run_summary") or "(none)" | ||
| runs = state.get("run_count", 0) | ||
|
|
||
| status_line = ( | ||
| "ENABLED" if enabled and not paused else | ||
| "PAUSED" if paused else | ||
| "DISABLED" | ||
| ) | ||
| print(f"curator: {status_line}") | ||
| print(f" runs: {runs}") | ||
| print(f" last run: {_fmt_ts(last_run)}") | ||
| print(f" last summary: {summary}") | ||
| print(f" interval: every {curator.get_interval_hours()}h") | ||
| print(f" stale after: {curator.get_stale_after_days()}d unused") | ||
| print(f" archive after: {curator.get_archive_after_days()}d unused") | ||
|
|
||
| rows = skill_usage.agent_created_report() | ||
| if not rows: | ||
| print("\nno agent-created skills") | ||
| return 0 | ||
|
|
||
| by_state = {"active": [], "stale": [], "archived": []} | ||
| pinned = [] | ||
| for r in rows: | ||
| state_name = r.get("state", "active") | ||
| by_state.setdefault(state_name, []).append(r) | ||
| if r.get("pinned"): | ||
| pinned.append(r["name"]) | ||
|
|
||
| print(f"\nagent-created skills: {len(rows)} total") | ||
| for state_name in ("active", "stale", "archived"): | ||
| bucket = by_state.get(state_name, []) | ||
| print(f" {state_name:10s} {len(bucket)}") | ||
|
|
||
| if pinned: | ||
| print(f"\npinned ({len(pinned)}): {', '.join(pinned)}") | ||
|
|
||
| # Show top 5 least-recently-used active skills | ||
| active = sorted( | ||
| by_state.get("active", []), | ||
| key=lambda r: r.get("last_used_at") or r.get("created_at") or "", | ||
| )[:5] | ||
| if active: | ||
| print("\nleast recently used (top 5):") | ||
| for r in active: | ||
| last = _fmt_ts(r.get("last_used_at")) | ||
| print(f" {r['name']:40s} use={r.get('use_count', 0):3d} last_used={last}") | ||
|
|
||
| return 0 | ||
|
|
||
|
|
||
| def _cmd_run(args) -> int: | ||
| from agent import curator | ||
| if not curator.is_enabled(): | ||
| print("curator: disabled via config; enable with `curator.enabled: true`") | ||
| return 1 | ||
|
|
||
| print("curator: running review pass...") | ||
|
|
||
| def _on_summary(msg: str) -> None: | ||
| print(msg) | ||
Check failureCode scanning / CodeQL Clear-text logging of sensitive information High
This expression logs
sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (secret) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs sensitive data (password) Error loading related location Loading This expression logs [sensit |
||
|
|
||
|
|
||
| result = curator.run_curator_review( | ||
| on_summary=_on_summary, | ||
| synchronous=bool(args.synchronous), | ||
| ) | ||
| auto = result.get("auto_transitions", {}) | ||
| if auto: | ||
| print( | ||
| f"auto: checked={auto.get('checked', 0)} " | ||
| f"stale={auto.get('marked_stale', 0)} " | ||
| f"archived={auto.get('archived', 0)} " | ||
| f"reactivated={auto.get('reactivated', 0)}" | ||
| ) | ||
| if not args.synchronous: | ||
| print("llm pass running in background — check `hermes curator status` later") | ||
| return 0 | ||
|
|
||
|
|
||
| def _cmd_pause(args) -> int: | ||
| from agent import curator | ||
| curator.set_paused(True) | ||
| print("curator: paused") | ||
| return 0 | ||
|
|
||
|
|
||
| def _cmd_resume(args) -> int: | ||
| from agent import curator | ||
| curator.set_paused(False) | ||
| print("curator: resumed") | ||
| return 0 | ||
|
|
||
|
|
||
| def _cmd_pin(args) -> int: | ||
| from tools import skill_usage | ||
| if not skill_usage.is_agent_created(args.skill): | ||
| print( | ||
| f"curator: '{args.skill}' is bundled or hub-installed — cannot pin " | ||
| "(only agent-created skills participate in curation)" | ||
| ) | ||
| return 1 | ||
| skill_usage.set_pinned(args.skill, True) | ||
| print(f"curator: pinned '{args.skill}' (will bypass auto-transitions)") | ||
| return 0 | ||
|
|
||
|
|
||
| def _cmd_unpin(args) -> int: | ||
| from tools import skill_usage | ||
| skill_usage.set_pinned(args.skill, False) | ||
| print(f"curator: unpinned '{args.skill}'") | ||
| return 0 | ||
|
|
||
|
|
||
| def _cmd_restore(args) -> int: | ||
| from tools import skill_usage | ||
| ok, msg = skill_usage.restore_skill(args.skill) | ||
| print(f"curator: {msg}") | ||
| return 0 if ok else 1 | ||
|
|
||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # argparse wiring (called from hermes_cli.main) | ||
| # --------------------------------------------------------------------------- | ||
|
|
||
| def register_cli(parent: argparse.ArgumentParser) -> None: | ||
| """Attach `curator` subcommands to *parent*. | ||
|
|
||
| main.py calls this with the ArgumentParser returned by | ||
| ``subparsers.add_parser("curator", ...)``. | ||
| """ | ||
| parent.set_defaults(func=lambda a: (parent.print_help(), 0)[1]) | ||
| subs = parent.add_subparsers(dest="curator_command") | ||
|
|
||
| p_status = subs.add_parser("status", help="Show curator status and skill stats") | ||
| p_status.set_defaults(func=_cmd_status) | ||
|
|
||
| p_run = subs.add_parser("run", help="Trigger a curator review now") | ||
| p_run.add_argument( | ||
| "--sync", "--synchronous", dest="synchronous", action="store_true", | ||
| help="Wait for the LLM review pass to finish (default: background thread)", | ||
| ) | ||
| p_run.set_defaults(func=_cmd_run) | ||
|
|
||
| p_pause = subs.add_parser("pause", help="Pause the curator until resumed") | ||
| p_pause.set_defaults(func=_cmd_pause) | ||
|
|
||
| p_resume = subs.add_parser("resume", help="Resume a paused curator") | ||
| p_resume.set_defaults(func=_cmd_resume) | ||
|
|
||
| p_pin = subs.add_parser("pin", help="Pin a skill so the curator never auto-transitions it") | ||
| p_pin.add_argument("skill", help="Skill name") | ||
| p_pin.set_defaults(func=_cmd_pin) | ||
|
|
||
| p_unpin = subs.add_parser("unpin", help="Unpin a skill") | ||
| p_unpin.add_argument("skill", help="Skill name") | ||
| p_unpin.set_defaults(func=_cmd_unpin) | ||
|
|
||
| p_restore = subs.add_parser("restore", help="Restore an archived skill") | ||
| p_restore.add_argument("skill", help="Skill name") | ||
| p_restore.set_defaults(func=_cmd_restore) | ||
|
|
||
|
|
||
| def cli_main(argv=None) -> int: | ||
| """Standalone entry (also usable by hermes_cli.main fallthrough).""" | ||
| parser = argparse.ArgumentParser(prog="hermes curator") | ||
| register_cli(parser) | ||
| args = parser.parse_args(argv) | ||
| fn = getattr(args, "func", None) | ||
| if fn is None: | ||
| parser.print_help() | ||
| return 0 | ||
| return int(fn(args) or 0) | ||
|
|
||
|
|
||
| if __name__ == "__main__": # pragma: no cover | ||
| sys.exit(cli_main()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.