fix(gateway): harden StreamingConfig bool and numeric coercion#16463
Merged
teknium1 merged 1 commit intoMay 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR hardens gateway streaming config parsing so malformed or quoted config values do not silently change runtime behavior or crash config loading.
Before this change,
gateway.config.StreamingConfig.from_dict()leftenableduncoerced and parsed numeric fields with directfloat()/int()calls. That caused two concrete problems:streaming.enabled: "false"could remain truthy instead of disabling streaming.edit_interval: "oops"could raise during config loading instead of falling back safely.This approach is the right fix because it keeps the change narrowly scoped to the config parser, aligns
StreamingConfigwith the existing coercion patterns already used elsewhere in gateway config, and adds regression coverage for both failure modes.Type of Change
Changes Made
gateway/config.pyStreamingConfig.from_dict()to:enabledvia the existing bool-normalization pathedit_intervalbuffer_thresholdfresh_final_after_secondstests/gateway/test_config.pyfor:"false"onstreaming.enabledHow to Test
streaming.enabled: "false"and verify it is treated as disabled instead of truthy.edit_interval: "oops"and verify gateway config loading falls back to defaults instead of raising.Expected result: 35 passed
Checklist
Code
Documentation & Housekeeping