Preserve document follow up type when merging queued gateway events#16589
Closed
hharry11 wants to merge 1 commit into
Closed
Preserve document follow up type when merging queued gateway events#16589hharry11 wants to merge 1 commit into
hharry11 wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve non-text media semantics when merging queued gateway follow-ups.
Previously, if a busy session queued a text follow-up and then received a document follow-up, the merged pending event could remain typed as
TEXT. That caused downstream document-specific handling to be skipped, so the attachment was not treated as a document on the next turn.Root cause
merge_pending_message_event()only promoted merged events toPHOTO. For other media types, a queuedTEXTevent could keep its original type even after inheriting document media payloads.Fix
When merging into an existing queued event:
PHOTOprecedence behavior unchangedTEXTand the incoming event is a non-text media type, promote the merged event to the incoming message typeThis keeps the fix narrow and avoids broader refactoring of merge precedence.
Testing
Added regression test:
tests/gateway/test_session_race_guard.py::test_merge_pending_message_event_promotes_document_followups_over_textVerified result:
1 passed