fix(tui): recover fragmented SGR mouse reports#18113
Merged
Merged
Conversation
alt-glitch
added
type/bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves TUI robustness around terminal input/mouse handling by (1) resetting additional sticky terminal modes at process boundaries and (2) recovering fragmented SGR mouse report “tails” that can otherwise leak into prompt text.
Changes:
- Extend the terminal mode reset sequence to disable more mouse/locator/focus-related modes.
- Add parsing logic to detect and re-synthesize fragmented SGR mouse report fragments embedded in text tokens.
- Add/extend Vitest coverage for terminal mode resets and fragmented SGR mouse recovery behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui-tui/src/lib/terminalModes.ts | Adds additional terminal mode disable sequences to the reset string. |
| ui-tui/src/tests/terminalModes.test.ts | Updates assertions to cover the newly added reset sequences. |
| ui-tui/packages/hermes-ink/src/ink/parse-keypress.ts | Introduces fragmented SGR mouse fragment detection/parsing and updates text-token handling. |
| ui-tui/packages/hermes-ink/src/ink/parse-keypress.test.ts | Adds tests validating SGR fragment recovery and preservation of semicolon-heavy user text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
…use-fragments fix(tui): recover fragmented SGR mouse reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm test -- parse-keypress terminalModesscripts/run_tests.sh tests/cli/test_cli_terminal_response_sanitizer.py