fix(gateway): preserve thread routing for /update progress and prompts#18193
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #17465 (@Yukipukii1) onto current main.
Summary
/updatenow keeps progress streams, interactive prompts, timeout notices, and post-restart completion notifications in the originating thread/topic. Previously onlychat_idwas persisted, so every /update reply fell back to the parent chat when invoked from a Telegram topic, Discord thread, or Slack thread.Changes
gateway/run.py: persistthread_idin.update_pending.json; threadmetadata={"thread_id": ...}through the watcher's stream/prompt/timeout/final-notification sendsgateway/platforms/telegram.py:send_update_prompt()honorsmessage_thread_idgateway/platforms/discord.py:send_update_prompt()targets the thread channel when presentsend()already resolvesmetadata.thread_idto a thread_tstests/gateway/test_update_command.pyandtests/gateway/test_update_streaming.pyValidation
tests/gateway/test_update_command.py+tests/gateway/test_update_streaming.py— 48/48 passedthread_idreferences anywhere in the /update pending/watcher paths, so the reported routing loss is realCloses #17465. Contributor authorship preserved via cherry-pick + rebase-merge.