feat(gateway): add busy_ack_enabled config option to suppress ack messages#18194
Merged
Conversation
…sages When a user sends a message while the gateway is busy processing, an acknowledgment message is sent. This can be spammy for users who send rapid messages. Add display.busy_ack_enabled config option (default: true) to allow users to suppress these busy-input acknowledgment messages. Fixes #17457
- Move the disabled-ack guard above the debounce so we don't stamp _busy_ack_ts[session_key] when no ack was actually sent. Harmless (never read when disabled) but cosmetically off. - Document display.busy_ack_enabled in user-guide/messaging/index.md and HERMES_GATEWAY_BUSY_ACK_ENABLED in reference/environment-variables.md. - Add JezzaHehn to scripts/release.py AUTHOR_MAP for contributor credit. Follow-up to #17491 (Jezza Hehn).
alt-glitch
added
type/feature
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #17491 by @JezzaHehn onto current main, plus a timestamp-placement nit and docs.
Summary
Users can now set
display.busy_ack_enabled: falsein config.yaml to silence the ⚡/⏳/⏩ gateway reply that fires when a user sends input while the agent is busy. The input is still queued/steered/interrupts as normal — only the chat reply is suppressed. Fixes #17457.Changes
gateway/run.py: bridgedisplay.busy_ack_enabled→HERMES_GATEWAY_BUSY_ACK_ENABLEDat startup; early-return guard in_handle_active_session_busy_message()placed above the debounce cooldown so no_busy_ack_tstimestamp is stamped when no ack was sent.website/docs/reference/environment-variables.md: documentHERMES_GATEWAY_BUSY_ACK_ENABLED.website/docs/user-guide/messaging/index.md: documentdisplay.busy_ack_enabledalongsidebusy_input_mode.scripts/release.py: addjezzahehn@gmail.com→JezzaHehnto AUTHOR_MAP.Validation
truefalseFALSE(case)22/22 gateway busy-input tests pass on
scripts/run_tests.sh tests/gateway/ -k busy.Closes #17457.
Original PR: #17491 by @JezzaHehn — authorship preserved via rebase-merge.
Co-authored-by: Jezza Hehn jezzahehn@gmail.com