Skip to content

fix: kanban button#18358

Merged
austinpickett merged 1 commit into
mainfrom
fix/kanban-buton
May 1, 2026
Merged

fix: kanban button#18358
austinpickett merged 1 commit into
mainfrom
fix/kanban-buton

Conversation

@austinpickett
Copy link
Copy Markdown
Collaborator

What does this PR do?

Kanban dashboard plugin buttons stop using ad hoc Tailwind className overrides (fixed heights such as h-8, borders, hover utilities). Each design-system Button uses size="sm" only so label alignment matches @nous-research/ui and avoids the leading-0 + grid items-center issue when an explicit height was applied.

Bulk actions used the hermes-kanban-bulk-btn class; that hook is removed from JSX. plugins/kanban/dashboard/dist/style.css instead targets .hermes-kanban-bulk > button and .hermes-kanban-bulk-reassign > button so compact height, padding, and hover stay the same. Inline Create still flexes via .hermes-kanban-inline-create > .flex.gap-2:last-child > button:first-of-type { flex: 1 }.

disabled is unchanged on Apply, dependency + parent / + child, and status actions; only extra opacity-40 / cursor-not-allowed utility classes were removed in favor of the Button component’s built-in disabled styles.

Related Issue

N/A

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • plugins/kanban/dashboard/dist/index.js — all Buttons: size: "sm", drop className / cn(...) (filters, bulk bar, inline create, drawer, meta editors, description editor, dependency editor, status actions, error boundary).
  • plugins/kanban/dashboard/dist/style.css — replace .hermes-kanban-bulk-btn with .hermes-kanban-bulk > button and .hermes-kanban-bulk-reassign > button; add inline-create first-button flex: 1 next to .hermes-kanban-inline-create.

How to Test

  1. Run the Hermes web dashboard and open the Kanban plugin tab.
  2. Filter row: Nudge dispatcher and Refresh — labels centered, hover OK.
  3. Select card(s): bulk → ready / Complete / Archive / Apply / Clear — compact layout; Apply disabled until assignee (or path) allows action.
  4. Task drawer: Comment, meta Save / Cancel, description Save / Cancel, + parent / + child, status buttons — correct enabled/disabled and layout.
  5. Column inline create: Create still grows in the row; Cancel works.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

Optional: before/after for filter row and bulk bar buttons.

@alt-glitch alt-glitch added type/bug Something isn't working comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have labels May 1, 2026
@austinpickett austinpickett merged commit 05c6325 into main May 1, 2026
8 of 9 checks passed
@austinpickett austinpickett deleted the fix/kanban-buton branch May 1, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants