fix: kanban button#18358
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Kanban dashboard plugin buttons stop using ad hoc Tailwind
classNameoverrides (fixed heights such ash-8, borders, hover utilities). Each design-systemButtonusessize="sm"only so label alignment matches@nous-research/uiand avoids theleading-0+ griditems-centerissue when an explicit height was applied.Bulk actions used the
hermes-kanban-bulk-btnclass; that hook is removed from JSX.plugins/kanban/dashboard/dist/style.cssinstead targets.hermes-kanban-bulk > buttonand.hermes-kanban-bulk-reassign > buttonso compact height, padding, and hover stay the same. Inline Create still flexes via.hermes-kanban-inline-create > .flex.gap-2:last-child > button:first-of-type { flex: 1 }.disabledis unchanged on Apply, dependency + parent / + child, and status actions; only extraopacity-40/cursor-not-allowedutility classes were removed in favor of the Button component’s built-in disabled styles.Related Issue
N/A
Type of Change
Changes Made
plugins/kanban/dashboard/dist/index.js— allButtons:size: "sm", dropclassName/cn(...)(filters, bulk bar, inline create, drawer, meta editors, description editor, dependency editor, status actions, error boundary).plugins/kanban/dashboard/dist/style.css— replace.hermes-kanban-bulk-btnwith.hermes-kanban-bulk > buttonand.hermes-kanban-bulk-reassign > button; add inline-create first-buttonflex: 1next to.hermes-kanban-inline-create.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Optional: before/after for filter row and bulk bar buttons.