fix(gateway): honor configured goal turn budget#19423
Closed
paul-tian wants to merge 1 commit into
Closed
Conversation
paul-tian
force-pushed
the
fix/gateway-goal-max-turns-config
branch
from
1bf1196 to
35bbd53
Compare
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/goalto honor top-levelgoals.max_turnsfromconfig.yamlGatewayConfig, which does not carry the full top-level configTest plan
./venv/bin/python -m py_compile gateway/run.py tests/gateway/test_goal_max_turns_config.py./venv/bin/python -m pytest tests/gateway/test_goal_max_turns_config.py tests/tui_gateway/test_goal_command.py -qNotes
The CLI goal path already loads the full user config. The gateway path receives a
GatewayConfigdataclass, so the top-levelgoalsblock needs to be loaded from the full config before falling back to the default budget.