fix(gateway): clear queued reload skills notes on new/resume/branch#19431
Merged
Conversation
alt-glitch
added
type/bug
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #19372 by @molvikar onto current main.
Summary
Stale gateway state leak: the one-shot note queued by
/reload-skillsinself._pending_skills_reload_notes[session_key]could survive session-boundary flows like/new,/resume, and/branchand get prepended to the next message in a different conversation branch. Drop the note inside_clear_session_boundary_security_stateso it's scoped to the session that requested it.Changes
_pending_skills_reload_notes[session_key]in_clear_session_boundary_security_state(+6/-0)Validation
scripts/run_tests.sh tests/gateway/test_session_boundary_security_state.py → 5 passed
Original PR: #19372