fix(curator): protect hub skills by frontmatter name#19460
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Salvaged via PR #20194 (#20194). Your commit was cherry-picked onto current main with authorship preserved in git log; I added one test tweak ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILL.mdfrontmatter name, not only the hub slug.install_pathentries under the skills directory before reading frontmatter, so slug/display-name mismatches stay protected.getnotewhose installed skill is namedGet笔记.Why
Issue #19293 reports that the curator treats hub-installed skills with localized or otherwise non-slug
namefields as agent-created. The lock file tracks the hub slug, while curator candidate discovery compares the SKILL.md name, sogetnotedid not protectGet笔记.Verification
scripts/run_tests.sh tests/tools/test_skill_usage.py- 39 passed, 4 existing event-loop deprecation warningsFixes #19293