fix(browser): allow explicit CDP override without local agent-browser#19670
Merged
Conversation
Treat explicit CDP override mode as a valid browser backend even when agent-browser is absent, and add a regression test to prevent false-negative availability gating.
alt-glitch
added
type/bug
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #16070 onto current main.
Summary
check_browser_requirements()always required a localagent-browserbinary even whenBROWSER_CDP_URLwas set, producing a false negative for users who connect to a remote CDP endpoint directly (e.g. a sidecar Chrome, a pre-configured CDP tunnel). Treat_get_cdp_override()the same way as Camofox mode: valid backend, skip the local binary check.Validation
scripts/run_tests.sh tests/tools/test_browser_homebrew_paths.py -k cdp_override -> passed
Original PR: #16070